-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(net): move reth_eth_wire::DisconnectReason
to reth-eth-wire-types
#10006
Conversation
unsure why I get this error @Rjected @mattsse @DaniPopes ?
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
supportive, you're just missing eth-wire-types with arbitrary enabled as dev dep like
reth/crates/net/eth-wire/Cargo.toml
Line 43 in 05f391d
reth-primitives = { workspace = true, features = ["arbitrary"] } |
it is already |
the arb tests are usually feature gated like this @emhane I assume this can also be moved reth/crates/net/eth-wire/src/p2pstream.rs Lines 644 to 648 in f1cd10a
|
…types` (paradigmxyz#10006) Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
Ref #10002