Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Optimism feature from chainspec #8904

Closed
10 tasks done
Tracked by #7649
mattsse opened this issue Jun 17, 2024 · 1 comment · Fixed by #11722
Closed
10 tasks done
Tracked by #7649

Remove Optimism feature from chainspec #8904

mattsse opened this issue Jun 17, 2024 · 1 comment · Fixed by #11722
Labels
C-debt Refactor of code section that is hard to understand or maintain C-tracking-issue An issue that collects information about a broad development initiative M-prevent-stale Prevents old inactive issues/PRs from being closed due to inactivity

Comments

@mattsse
Copy link
Collaborator

mattsse commented Jun 17, 2024

Describe the feature

this is closely related to #7679

we should find a way to get rid of optimism specific stuff in chainspec, either by switching to name based hardforks, or a trait abstraction for chainspec.

in the short term, I think using named variants as described in #7679 would be easier and would allow adding additional hardforks and check functions via extension traits

or we go all the way and add trait for chainspec.

Additional context

No response

Tasks

  1. A-op-reth C-debt
    emhane
  2. A-op-reth C-debt
  3. A-op-reth C-debt
    emhane
  4. A-op-reth A-sdk C-debt
    emhane
  5. A-op-reth C-debt
  6. C-debt C-enhancement
  7. A-sdk
  8. A-op-reth C-debt D-good-first-issue
  9. D-good-first-issue
    garwahl
  10. A-op-reth C-enhancement D-good-first-issue
    greged93
@mattsse mattsse added C-enhancement New feature or request S-needs-design This issue requires design work to think about how it would best be accomplished labels Jun 17, 2024
Copy link
Contributor

github-actions bot commented Jul 9, 2024

This issue is stale because it has been open for 21 days with no activity.

@github-actions github-actions bot added the S-stale This issue/PR is stale and will close with no further activity label Jul 9, 2024
@mattsse mattsse added M-prevent-stale Prevents old inactive issues/PRs from being closed due to inactivity and removed S-stale This issue/PR is stale and will close with no further activity labels Jul 9, 2024
@emhane emhane removed the S-needs-design This issue requires design work to think about how it would best be accomplished label Aug 22, 2024
@emhane emhane added the C-tracking-issue An issue that collects information about a broad development initiative label Aug 22, 2024
@emhane emhane added C-debt Refactor of code section that is hard to understand or maintain and removed C-enhancement New feature or request labels Aug 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-debt Refactor of code section that is hard to understand or maintain C-tracking-issue An issue that collects information about a broad development initiative M-prevent-stale Prevents old inactive issues/PRs from being closed due to inactivity
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants