Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove op Genesis conversions from reth-chainspec #11396

Closed
Tracked by #8904
mattsse opened this issue Oct 1, 2024 · 1 comment · Fixed by #11415
Closed
Tracked by #8904

remove op Genesis conversions from reth-chainspec #11396

mattsse opened this issue Oct 1, 2024 · 1 comment · Fixed by #11415
Labels
A-op-reth Related to Optimism and op-reth C-debt Refactor of code section that is hard to understand or maintain D-good-first-issue Nice and easy! A great choice to get started

Comments

@mattsse
Copy link
Collaborator

mattsse commented Oct 1, 2024

we still have

impl From<Genesis> for ChainSpec {
fn from(genesis: Genesis) -> Self {
#[cfg(not(feature = "optimism"))]
{
into_ethereum_chain_spec(genesis)
}
#[cfg(feature = "optimism")]
{
into_optimism_chain_spec(genesis)
}
}
}

now that we have chainspec abstracted we can remove this conversion and replace with standalone op function which is used:

_ => Arc::new(OpChainSpec { inner: parse_custom_chain_spec(s)? }),

TODO

  • extract optimism specific From Genesis to optimism chainspec

we likely should do #11397 first, or maybe we need to this in one go

cc @greged93

@mattsse mattsse added C-debt Refactor of code section that is hard to understand or maintain A-op-reth Related to Optimism and op-reth D-good-first-issue Nice and easy! A great choice to get started labels Oct 1, 2024
@greged93
Copy link
Contributor

greged93 commented Oct 2, 2024

will tal!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-op-reth Related to Optimism and op-reth C-debt Refactor of code section that is hard to understand or maintain D-good-first-issue Nice and easy! A great choice to get started
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants