Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Access RPC types via alloy Network trait in EthApi #8780

Closed
5 tasks done
Tracked by #8988
emhane opened this issue Jun 12, 2024 · 1 comment
Closed
5 tasks done
Tracked by #8988

Access RPC types via alloy Network trait in EthApi #8780

emhane opened this issue Jun 12, 2024 · 1 comment
Labels
A-op-reth Related to Optimism and op-reth A-rpc Related to the RPC implementation C-debt Refactor of code section that is hard to understand or maintain M-prevent-stale Prevents old inactive issues/PRs from being closed due to inactivity

Comments

@emhane
Copy link
Member

emhane commented Jun 12, 2024 •
edited
Loading

Describe the feature

Replace alloy rpc types AnyTransactionReceipt, RichBlock and Transaction in EthApi trait, with Network trait.

https://github.com/alloy-rs/alloy/blob/251e11ebde5fae1b94652c5b0109d5d966726f55/crates/network/src/lib.rs#L48-L101

This will also have to happen for EngineEthApi, due to trait bound

reth/crates/rpc/rpc/src/engine.rs

Line 35 in b8cd7be

Eth: EthApiServer,

Additional context

No response

Tasks
Preview Give feedback
  1. chore(rpc): EthApiTypes trait for network specific error AT #9523
    A-op-reth A-rpc C-debt
  2. chore(rpc): config network specific transaction type in node builder #10417
    A-op-reth A-rpc A-sdk
  3. chore(rpc): remove use of extensible transaction + receipt types #9774
    A-op-reth A-rpc A-sdk C-debt
  4. Use alloy_network::Network::BlockResponse instead of reth_rpc_types::Block in RPC #10451
    A-rpc C-debt
    nkysg
  5. Use alloy_network::Network::ReceiptResponse instead of AnyTransactionReceipt in RPC #10452
    A-rpc C-debt
    malik672
@emhane emhane added C-debt Refactor of code section that is hard to understand or maintain A-rpc Related to the RPC implementation A-op-reth Related to Optimism and op-reth labels Jun 12, 2024
This was referenced Jun 12, 2024
Open
Closed
@emhane emhane mentioned this issue Jun 20, 2024
Closed
@emhane emhane added the S-blocked This cannot more forward until something else changes label Jun 24, 2024
@github-actions GitHub Actions
Copy link
Contributor

This issue is stale because it has been open for 21 days with no activity.

@github-actions github-actions bot added the S-stale This issue/PR is stale and will close with no further activity label Jul 16, 2024
@emhane emhane added M-prevent-stale Prevents old inactive issues/PRs from being closed due to inactivity and removed S-stale This issue/PR is stale and will close with no further activity labels Jul 16, 2024
This was referenced Jul 25, 2024
Merged
Merged
@emhane emhane mentioned this issue Aug 21, 2024
Merged
@emhane emhane removed the S-blocked This cannot more forward until something else changes label Aug 22, 2024
@emhane emhane closed this as completed Oct 26, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in Reth Tracker Oct 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-op-reth Related to Optimism and op-reth A-rpc Related to the RPC implementation C-debt Refactor of code section that is hard to understand or maintain M-prevent-stale Prevents old inactive issues/PRs from being closed due to inactivity
Projects
Reth Tracker
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(rpc): optimism rpc types paradigmxyz/reth
1 participant
@emhane