Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use alloy_network::Network::BlockResponse instead of reth_rpc_types::Block in RPC #10451

Closed
Tracked by #8780 ...
emhane opened this issue Aug 22, 2024 · 2 comments · Fixed by #10613
Closed
Tracked by #8780 ...

Use alloy_network::Network::BlockResponse instead of reth_rpc_types::Block in RPC #10451

emhane opened this issue Aug 22, 2024 · 2 comments · Fixed by #10613
Assignees
Labels
A-rpc Related to the RPC implementation C-debt Refactor of code section that is hard to understand or maintain

Comments

@emhane
Copy link
Member

emhane commented Aug 22, 2024

Describe the feature

Change

/// Adapter for network specific block type.
pub type RpcBlock<T> = Block<RpcTransaction<T>>;

to

/// Adapter for network specific block type.
pub type RpcBlock<T> = Block<<T as Network>::HeaderResponse, RpcTransaction<T>>;

blocked by alloy-rs/alloy#1177

Additional context

No response

@emhane emhane added S-blocked This cannot more forward until something else changes C-debt Refactor of code section that is hard to understand or maintain A-rpc Related to the RPC implementation labels Aug 22, 2024
@nkysg
Copy link
Contributor

nkysg commented Aug 26, 2024

May I take this?

@emhane emhane removed the S-blocked This cannot more forward until something else changes label Aug 26, 2024
@emhane
Copy link
Member Author

emhane commented Aug 26, 2024

the pr will be blocked by latest alloy release though @nkysg , you would have to pull in the alloy main branch as dep in reth workspace to develop, and label pr as blocked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rpc Related to the RPC implementation C-debt Refactor of code section that is hard to understand or maintain
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants