chore: remove more redundant BlockExecutionError variants (#9905)

paradigmxyz · Jul 30, 2024 · dec0c44 · dec0c44
1 parent bc48459
commit dec0c44
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 21 deletions.
diff --git a/crates/blockchain-tree-api/src/error.rs b/crates/blockchain-tree-api/src/error.rs
@@ -291,8 +291,6 @@ impl InsertBlockErrorKind {
                     // these are internal errors, not caused by an invalid block
                     BlockExecutionError::LatestBlock(_) |
                     BlockExecutionError::Pruning(_) |
-                    BlockExecutionError::CanonicalRevert { .. } |
-                    BlockExecutionError::CanonicalCommit { .. } |
                     BlockExecutionError::AppendChainDoesntConnect { .. } |
                     BlockExecutionError::Other(_) => false,
                 }

diff --git a/crates/evm/execution-errors/src/lib.rs b/crates/evm/execution-errors/src/lib.rs
@@ -125,18 +125,6 @@ pub enum BlockExecutionError {
     /// Consensus error, transparently wrapping `ConsensusError`
     #[error(transparent)]
     Consensus(#[from] ConsensusError),
-    /// Transaction error on revert with inner details
-    #[error("transaction error on revert: {inner}")]
-    CanonicalRevert {
-        /// The inner error message
-        inner: String,
-    },
-    /// Transaction error on commit with inner details
-    #[error("transaction error on commit: {inner}")]
-    CanonicalCommit {
-        /// The inner error message.
-        inner: String,
-    },
     /// Error when appending chain on fork is not possible
     #[error(
         "appending chain on fork (other_chain_fork:?) is not possible as the tip is {chain_tip:?}"
@@ -180,13 +168,6 @@ impl BlockExecutionError {
         }
     }
 
-    /// Returns `true` if the error is fatal.
-    ///
-    /// This represents an unrecoverable database related error.
-    pub const fn is_fatal(&self) -> bool {
-        matches!(self, Self::CanonicalCommit { .. } | Self::CanonicalRevert { .. })
-    }
-
     /// Returns `true` if the error is a state root error.
     pub const fn is_state_root_error(&self) -> bool {
         matches!(self, Self::Validation(BlockValidationError::StateRoot(_)))