Merge pull request #135 from anu-ka/test-initialization

Test for invalid initialization options

tests/lsp_test_client/session.py

@@ -16,6 +16,8 @@
 
 
 PUBLISH_DIAGNOSTICS = "textDocument/publishDiagnostics"
+WINDOW_LOG_MESSAGE = "window/logMessage"
+WINDOW_SHOW_MESSAGE = "window/showMessage"
 
 
 class LspSession(MethodDispatcher):
@@ -55,7 +57,11 @@ def __enter__(self):
             os.fdopen(self._sub.stdout.fileno(), "rb")
         )
 
-        dispatcher = {PUBLISH_DIAGNOSTICS: self._publish_diagnostics}
+        dispatcher = {
+            PUBLISH_DIAGNOSTICS: self._publish_diagnostics,
+            WINDOW_SHOW_MESSAGE: self._window_show_message,
+            WINDOW_LOG_MESSAGE: self._window_log_message,
+        }
         self._endpoint = Endpoint(dispatcher, self._writer.write)
         self._thread_pool.submit(self._reader.listen, self._endpoint.consume)
         return self
@@ -218,11 +224,29 @@ def _default_handler(_params):
 
     def _publish_diagnostics(self, publish_diagnostics_params):
         """Internal handler for text document publish diagnostics."""
+        return self._handle_notification(
+            PUBLISH_DIAGNOSTICS, publish_diagnostics_params
+        )
+
+    def _window_log_message(self, window_log_message_params):
+        """Internal handler for window log message."""
+        return self._handle_notification(
+            WINDOW_LOG_MESSAGE, window_log_message_params
+        )
+
+    def _window_show_message(self, window_show_message_params):
+        """Internal handler for window show message."""
+        return self._handle_notification(
+            WINDOW_SHOW_MESSAGE, window_show_message_params
+        )
+
+    def _handle_notification(self, notification_name, params):
+        """Internal handler for notifications."""
         fut = Future()
 
         def _handler():
-            callback = self.get_notification_callback(PUBLISH_DIAGNOSTICS)
-            callback(publish_diagnostics_params)
+            callback = self.get_notification_callback(notification_name)
+            callback(params)
             fut.set_result(None)
 
         self._thread_pool.submit(_handler)

tests/lsp_tests/test_init_options.py

@@ -0,0 +1,53 @@
+"""Tests for initialization options over language server protocol."""
+
+import copy
+from threading import Event
+
+from hamcrest import assert_that, is_
+
+from tests.lsp_test_client import defaults, session
+
+
+def test_invalid_initialization_options() -> None:
+    """Test what happens when invalid initialization is sent."""
+    initialize_params = copy.deepcopy(defaults.VSCODE_DEFAULT_INITIALIZE)
+    initialize_params["initializationOptions"]["diagnostics"] = 1
+
+    with session.LspSession() as ls_session:
+        window_show_message_done = Event()
+        window_log_message_done = Event()
+
+        actual = []
+
+        def _window_show_message_handler(params):
+            actual.append(params)
+            window_show_message_done.set()
+
+        ls_session.set_notification_callback(
+            session.WINDOW_SHOW_MESSAGE, _window_show_message_handler
+        )
+
+        def _window_log_message_handler(params):
+            actual.append(params)
+            window_log_message_done.set()
+
+        ls_session.set_notification_callback(
+            session.WINDOW_LOG_MESSAGE, _window_log_message_handler
+        )
+
+        ls_session.initialize(initialize_params)
+
+        window_show_message_done.wait(5)
+        window_log_message_done.wait(5)
+        expected = [
+            {
+                "type": 1,
+                "message": "Invalid InitializationOptions, using defaults: 1 validation error for InitializationOptions\ndiagnostics\n  value is not a valid dict (type=type_error.dict)",
+            },
+            {
+                "type": 1,
+                "message": "Invalid InitializationOptions, using defaults: 1 validation error for InitializationOptions\ndiagnostics\n  value is not a valid dict (type=type_error.dict)",
+            },
+        ]
+
+        assert_that(actual, is_(expected))