Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic window opening direction #829

Merged
merged 16 commits into from
Apr 19, 2024
Merged

Conversation

jtaala
Copy link
Collaborator

@jtaala jtaala commented Apr 18, 2024

Fixes #727.

This PR adds the ability to change the "direction" that new windows will be opened (e.g. to the right/left of the current window).

It also adds:

  • an icon on the Gnome topbar indicating the current mode;
  • setting to hide this icon;
  • setting to set the modes available for cycling through (e.g. right, left, start, end);
  • a keybind to cycle these modes (Shift+Super+w);
Screencast.from.2024-04-19.08-06-43.webm

@github-actions github-actions bot changed the base branch from release to develop April 18, 2024 00:29
@paperwm paperwm deleted a comment from github-actions bot Apr 18, 2024
@jtaala jtaala marked this pull request as draft April 18, 2024 00:30
@jtaala jtaala force-pushed the dynamic-window-opening-direction branch 2 times, most recently from 0e8c386 to 11a3848 Compare April 18, 2024 11:24
@jtaala jtaala force-pushed the dynamic-window-opening-direction branch from 11a3848 to badd63b Compare April 18, 2024 11:25
@jtaala jtaala marked this pull request as ready for review April 18, 2024 13:10
@jtaala jtaala added the merging soon Label for PRs that are planned to be merged soon (usually within the next week) label Apr 18, 2024
@jtaala jtaala requested review from Lythenas and valpackett April 18, 2024 22:09
@jtaala
Copy link
Collaborator Author

jtaala commented Apr 18, 2024

P.S. @valpackett, I've changed the icon for the edge mode since the original one reminded me of fullscreen mode.

Having said that, if you have strong feelings towards the original icon let me know (and not the new one) let me know!

P.S.S. have a look at https://flathub.org/apps/org.gnome.design.IconLibrary and let me know if any other ones from there look okay/better.

@valpackett
Copy link
Collaborator

P.S. @valpackett, I've changed the icon for the edge mode since the original one reminded me of fullscreen mode.

The new one looks generally better, the edges it shows are rather thin I guess but that's fine

@jtaala jtaala merged commit 7129928 into develop Apr 19, 2024
@jtaala jtaala deleted the dynamic-window-opening-direction branch April 19, 2024 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merging soon Label for PRs that are planned to be merged soon (usually within the next week)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dynamic window opening direction
2 participants