Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust CI Matrix Ruby Version to 3.0+ to align with gemspec #1499

Merged
merged 2 commits into from
Nov 10, 2024

Conversation

taketo1113
Copy link
Contributor

Summary

This PR addresses inconsistencies between the Ruby versions specified in the gemspec and the CI matrix.
In paper_trail v.16.0.0, the gemspec requires Ruby 3.0 or higher, while the CI matrix specifies Ruby 3.1 or higher.

The CI matrix was updated to require Ruby 3.1+ in the PR (#1485), where Ruby 3.0 was temporarily removed to support Rails 7.2

Decide what to do with Ruby 3.0 tests. Rails 7.2.0 does not support this version, so you should completely change test workflow. I temporarily removed it.

Details

This PR changes the Ruby version in the CI matrix to 3.0 or higher to align with the required_ruby_version in the gemspec.
Additionally, the Compatibility section in the README has been updated to match the gemspec.

Additional information

If support for Ruby 3.0 is dropped, I think it will also be necessary to update the gemspec and RuboCop versions.
https://github.com/paper-trail-gem/paper_trail/blob/master/.github/CONTRIBUTING.md#lowest-supported-ruby-version

Check the following boxes:

  • Wrote good commit messages.
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new
    code introduces user-observable changes.
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences.

@fatkodima fatkodima merged commit 94e9c0d into paper-trail-gem:master Nov 10, 2024
9 checks passed
@taketo1113 taketo1113 deleted the ci-ruby-3.0 branch November 11, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants