Add important dates feature #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@trevor-viljoen Great work! Could you please fix the pep8 issues as described in the codeclimate issue sbefore I merge? |
trevor-viljoen
force-pushed
the
feature/important_dates
branch
from
3fbb388 to
8fc560a
Compare
dowski
reviewed
Apr 3, 2018
mlbgame/__init__.py
Outdated
| @@ -228,6 +228,12 @@ def game_events(game_id): | |||
| return [mlbgame.events.Inning(data[x], x) for x in data] | |||
|
|
|||
|
|
|||
| def important_dates(year=datetime.now().year): | |||
There was a problem hiding this comment.
I suggest using year=None here and then assigning year to datetime.now().year in the function body if None is passed in.
The way it's currently done the default value for year will be calculated at import time.
mlbgame/info.py
Outdated
| wildcard_teams | ||
| year | ||
| """ | ||
| def dtfmt(self, my_date): |
There was a problem hiding this comment.
Slight simplification if you want: this can be a function in the module instead of a method on this class. Then you can just refer to it as dtfmt when calling it below instead of self.dtfmt.
mlbgame/info.py
Outdated
| return '' | ||
| return my_date.strftime('%A, %B %d') | ||
|
|
||
| def strformat(self, my_str, args): |
There was a problem hiding this comment.
Similar suggestion as above.
Make date_format and str_format module functions
|
@trevor-viljoen Looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds #84. Example and sample output: