Where are the abbreviations for setExpirationTime's input string documented?

[smohadjer]

I was wondering if setExpirationTime('2m') means two months or two minutes and had to dig into source code to find out.

[panva]

It would appear they are not.

[panva]

I'm not allowing month/year because they're not exactly convertable to a fixed number of days. A year can be 365/366 depending on the leap year and month can be 28, 29 (leap feb), 30, 31.

[smohadjer]

I see. Totally right!

[big-kahuna-burger]

But you are allowing for years with a regex and fall-through switch using fractional days.

You are not allowing months only, which makes sense given the non-fixed nature of months semantically and possible prefix confusions when using 'm' for minutes.

[panva]

Ah right. Years are there with a 365.25 days value which is also imprecise even on average since every 100 years there's no leap.

[big-kahuna-burger]

Ah right. Years are there with a 365.25 days value which is also imprecise even on average since every 100 years there's no leap.

Ikr, it's complete madness when you dive deep into calendar implementations we use and why :)

[panva]

Resolved in #619