Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guard against fake interpreters. #1500

Merged
merged 1 commit into from
Oct 30, 2021
Merged

Conversation

jsirois
Copy link
Member

@jsirois jsirois commented Oct 30, 2021

Instead of assuming an interpreter that exits 0 is valid, force the
purported interpreter to execute some code that outputs a file to
both prove it's a binary that can execute Python code and identify
itself.

Fixes #1494

Instead of assuming an interpreter that exits 0 is valid, force the
purported interpreter to execute some code that outputs a file to
both prove its a binary that can execute Python code and identify
itself.

Fixes pex-tool#1494
@jsirois
Copy link
Member Author

jsirois commented Oct 30, 2021

I <3 macOS

@jsirois jsirois mentioned this pull request Oct 30, 2021
1 task
Copy link
Contributor

@tdyas tdyas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jsirois jsirois merged commit 8b67835 into pex-tool:main Oct 30, 2021
@jsirois jsirois deleted the issues/1494 branch October 30, 2021 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pex stops interpreter search if even one intepreter fails to identify itself
2 participants