Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve interpreter identification failure logging #689

Closed
jsirois opened this issue Mar 26, 2019 · 1 comment
Closed

Improve interpreter identification failure logging #689

jsirois opened this issue Mar 26, 2019 · 1 comment
Assignees

Comments

@jsirois
Copy link
Member

jsirois commented Mar 26, 2019

Currently, when a binary that looks like it might be a python binary is executed to determine the potential python binary's identity, failures from valid but misconfigured python binaries are more opaque than is useful to debug the underlying misconfiguration:
https://github.com/pantsbuild/pex/blob/e906d4d6430071dbe7269a13b48641979d60c005/pex/interpreter.py#L348-L364

In particular, except Exception as e drops details on the floor in the case where the exception is a pex.executor.Executor.NonZeroExit since its __str__ does not include its stdout or stderr fields. Make sure these are logged.

@jsirois jsirois self-assigned this Aug 12, 2024
@jsirois
Copy link
Member Author

jsirois commented Aug 12, 2024

It looks like this was all fixed up though a series of changes culminating in #1500. In short, interpreter identification is now done via the Job system and Job errors are retained and printed. These job errors include the stderr from the Job, which provides good detail on what the issue was identifying the interpreter.

@jsirois jsirois closed this as completed Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant