upgrade Rust to 1.43.1 #9681
upgrade Rust to 1.43.1 #9681
Conversation
|
With clippy fixes, everything passes except the self-test which appears to be failing because of failing to download some artifacts. |
Restarted to see if this was network flakiness. |
|
Failed for infra reasons again: |
tdyas
force-pushed
the
upgrade_rust_to_1.43.0
branch
from
f8c8211 to
ef129eb
Compare
This happens when your uploaded But, the restart I did didn't help. It had the same error as before. |
There was a merge conflict any way, so I just rebased and force pushed off of master. |
|
Failing to fetch grpc is weird. I'll wipe the cache for this. EDIT: Wiped and restarted those shards. |
|
It is still failing because of the gRPC issue (assuming the cache wipe occurred). |
tdyas
force-pushed
the
upgrade_rust_to_1.43.0
branch
from
ef129eb to
8a60fc6
Compare
|
Still an infra failure at https://travis-ci.com/github/pantsbuild/pants/jobs/333012689#L775 related to grpcio and trying to clone the repository. |
The error I see in there is: I'd look at the differences between the OS packages installed on the lint shard and on the bootstrap shards. |
|
From what I can tell, from cargo 1.42.0 to 1.43.0, the version of the libgit2-sys crate went from 0.10.0 to 0.12.0. A similar error message re zlib was reported to that crate in rust-lang/git2-rs#546, but resolved as "spurious." |
tdyas
force-pushed
the
upgrade_rust_to_1.43.0
branch
from
57197fa to
9e1f611
Compare
|
1.43.1 came out, appears to fix it locally on my Ubuntu VM. Will see if CI agrees. |
|
I repro this failure locally if I remove EDIT: Also, it looks like it's been reported here: rust-lang/cargo#8258 EDIT2: I'll try working around this by filtering out that submodule. |
Ah good, somebody did a more in-depth look at the issue. As reported earlier, I had only ended up at the libgit2-sys version bump when I last looked at this, but gave up when nothing obvious stood out. I wonder if we could just fork that problematic repo to somewhere not on the chromium.googlesource.com server, and point Cargo there instead. |
|
And a libgit2 issue was opened as well: libgit2/libgit2#5525 Seems like they isolated it to one commit. Of course, that commit is large change to their HTTP code. |
# Delete this line to force CI to run the JVM tests. [ci skip-jvm-tests]
|
It looks like the submodule changes might work? Rebasing and sanity checking and will push shortly. |
[ci skip-jvm-tests]
fixed by upgrading derivative to latest
Clippy output:
Checking process_execution v0.0.1 (/Users/tdyas/TC/pants/src/rust/engine/process_execution)
error: this match could be written as a `let` statement
--> process_execution/src/remote.rs:37:1
|
37 | #[derivative(Debug)]
| ^^^^^^^^^^^^^^^^^^^^
|
note: the lint level is defined here
--> process_execution/src/lib.rs:7:3
|
7 | clippy::all,
| ^^^^^^^^^^^
= note: `#[deny(clippy::match_single_binding)]` implied by `#[deny(clippy::all)]`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding
help: consider using `let` statement
|
37 | let Derivative = #[derivative(Debug)];
38 | Derivative
See mcarton/rust-derivative#58. Fix was released in vw2.1.1.
# Delete this line to force CI to run the JVM tests.
[ci skip-jvm-tests]
[ci skip-jvm-tests]
# Delete this line to force CI to run the JVM tests. [ci skip-jvm-tests]
# Delete this line to force CI to run the JVM tests. [ci skip-jvm-tests]
# Delete this line to force CI to run the JVM tests. [ci skip-jvm-tests]
…ust-lang/cargo#8258. # Delete this line to force CI to run the JVM tests. [ci skip-jvm-tests]
stuhood
force-pushed
the
upgrade_rust_to_1.43.0
branch
from
6bb8424 to
561beab
Compare
Problem
Staying current with Rust stable releases.
Solution
Upgrade to the latest stable release 1.43.0.
Result
Native engine builds and passes tests just fine.
./pants test src/python::fails eventually with:I have the full log, going to see if CI sees the same result before pursuing.