Port the bulk of the process_execution crate to async/await #9676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 30, 2020 22:45
[ci skip-jvm-tests]
# Delete this line to force CI to run the JVM tests. [ci skip-jvm-tests]
stuhood
requested review from
illicitonion,
pierrechevalier83,
gshuflin and
jsirois
and removed request for
illicitonion
Eric-Arellano
approved these changes
May 1, 2020
| @@ -24,11 +24,11 @@ | |||
| #![allow(clippy::new_without_default, clippy::new_ret_no_self)] | |||
| // Arc<Mutex> can be more clear than needing to grok Orderings: | |||
| #![allow(clippy::mutex_atomic)] | |||
| #![type_length_limit = "7000100"] | |||
| #![type_length_limit = "32185118"] | |||
There was a problem hiding this comment.
Why this change? It looks like we're now 32x times the default: https://doc.rust-lang.org/reference/attributes/limits.html#the-type_length_limit-attribute
There was a problem hiding this comment.
async/await generates very large per-method types that describe an anonymous struct holding the state machine for the run... luckily you never see them (in error messages, for example). But they're there.
I went down a bit of a rabbit hole looking for something clearly stating that this is fine, but didn't find anything that definitive. The best I could find is that they're continuing to try and improve it: rust-lang/rust#46477
| } | ||
| }) | ||
| .and_then( |
There was a problem hiding this comment.
Wow. What a difference 👏
Eric-Arellano
approved these changes
May 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We're planning to instrument process execution with additional workunits, but it can be challenging to identify critical sections in the presence of combinators.
Solution
async/await for the bulk of the process_execution crate.