Add Target.has_field() as sugar for Target.has_fields()
#9314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eric-Arellano
requested review from
illicitonion,
TansyArron,
pierrechevalier83,
blorente and
gshuflin
stuhood
approved these changes
Mar 17, 2020
| custom subclass `PythonSources`, both `python_tgt.has_field(PythonSources)` and | ||
| `python_tgt.has_field(Sources)` will return True. | ||
| """ | ||
| return self.has_fields([field]) |
There was a problem hiding this comment.
It might be a micro optimization, but this method could probably have its own implementation to avoid the extra collection classes that are created here.
There was a problem hiding this comment.
Hm, I looked at factoring that out and it wasn't very pretty. I think this is likely a micro optimization.
We'll probably want to profile the Target API once the dust settles, and maybe this ends up making a difference to change down the road.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main idiom we'll use for Target API code is:
has_field(PythonSources)is simpler to write thanhas_fields([PythonSources]). Because we will use this so often, this is nice sugar to add.--
This also documents the 3 main methods exposed by
Target.