Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop using hacky ExecuteProcessRequest to inject missing __init__.py files #8939

Closed
wants to merge 1 commit into from
Closed

Stop using hacky ExecuteProcessRequest to inject missing __init__.py files #8939

wants to merge 1 commit into from

Conversation

Eric-Arellano
Copy link
Contributor

Beyond readability, this improves caching and performance.

@Eric-Arellano
Copy link
Contributor Author

Eric-Arellano commented Jan 9, 2020 •
edited by stuhood
Loading

This fails with:

 (ChrootedPythonSources, [HydratedTargets], [Get(SourceRootStrippedSources, HydratedTarget), Get(Digest, DirectoriesToMerge), Get(InjectedInitDigest, Digest)], prepare_chrooted_python_sources()):
    Ambiguous rules to compute HydratedTargets with parameter types (AddressSpecs+BuildFileAddresses):
      (HydratedTargets, [BuildFileAddresses], [Get(HydratedTarget, Address)], hydrated_targets()) for AddressSpecs
      (HydratedTargets, [BuildFileAddresses], [Get(HydratedTarget, Address)], hydrated_targets()) for BuildFileAddresses
    Ambiguous rules to compute HydratedTargets with parameter types (AddressSpecs+BuildFileAddresses+Digest):
      (HydratedTargets, [BuildFileAddresses], [Get(HydratedTarget, Address)], hydrated_targets()) for AddressSpecs
      (HydratedTargets, [BuildFileAddresses], [Get(HydratedTarget, Address)], hydrated_targets()) for BuildFileAddresses
    Ambiguous rules to compute HydratedTargets with parameter types (AddressSpecs+BuildFileAddresses+Digest+HydratedTargets):
      (HydratedTargets, [BuildFileAddresses], [Get(HydratedTarget, Address)], hydrated_targets()) for AddressSpecs
      (HydratedTargets, [BuildFileAddresses], [Get(HydratedTarget, Address)], hydrated_targets()) for BuildFileAddresses
      Param(HydratedTargets)
    Ambiguous rules to compute HydratedTargets with parameter types (AddressSpecs+BuildFileAddresses+Digest+HydratedTargets+OptionsBootstrapper):
      (HydratedTargets, [BuildFileAddresses], [Get(HydratedTarget, Address)], hydrated_targets()) for AddressSpecs
      (HydratedTargets, [BuildFileAddresses], [Get(HydratedTarget, Address)], hydrated_targets()) for BuildFileAddresses
      Param(HydratedTargets)
    Ambiguous rules to compute HydratedTargets with parameter types (AddressSpecs+BuildFileAddresses+Digest+HydratedTargets+OptionsBootstrapper+OwnersRequest):
      (HydratedTargets, [BuildFileAddresses], [Get(HydratedTarget, Address)], hydrated_targets()) for AddressSpecs
      (HydratedTargets, [BuildFileAddresses], [Get(HydratedTarget, Address)], hydrated_targets()) for BuildFileAddresses
      (HydratedTargets, [BuildFileAddresses], [Get(HydratedTarget, Address)], hydrated_targets()) for OwnersRequest
      Param(HydratedTargets)
    Ambiguous rules to compute HydratedTargets with parameter types (AddressSpecs+BuildFileAddresses+Digest+HydratedTargets+OwnersRequest):
      (HydratedTargets, [BuildFileAddresses], [Get(HydratedTarget, Address)], hydrated_targets()) for AddressSpecs
      (HydratedTargets, [BuildFileAddresses], [Get(HydratedTarget, Address)], hydrated_targets()) for BuildFileAddresses
      (HydratedTargets, [BuildFileAddresses], [Get(HydratedTarget, Address)], hydrated_targets()) for OwnersRequest
      Param(HydratedTargets)
    Ambiguous rules to compute HydratedTargets with parameter types (AddressSpecs+BuildFileAddresses+Digest+OptionsBootstrapper):
      (HydratedTargets, [BuildFileAddresses], [Get(HydratedTarget, Address)], hydrated_targets()) for AddressSpecs
      (HydratedTargets, [BuildFileAddresses], [Get(HydratedTarget, Address)], hydrated_targets()) for BuildFileAddresses
    Ambiguous rules to compute HydratedTargets with parameter types (AddressSpecs+BuildFileAddresses+Digest+OptionsBootstrapper+OwnersRequest):
      (HydratedTargets, [BuildFileAddresses], [Get(HydratedTarget, Address)], hydrated_targets()) for AddressSpecs
      (HydratedTargets, [BuildFileAddresses], [Get(HydratedTarget, Address)], hydrated_targets()) for BuildFileAddresses
      (HydratedTargets, [BuildFileAddresses], [Get(HydratedTarget, Address)], hydrated_targets()) for OwnersRequest
    Ambiguous rules to compute HydratedTargets with parameter types (AddressSpecs+BuildFileAddresses+Digest+OwnersRequest):
      (HydratedTargets, [BuildFileAddresses], [Get(HydratedTarget, Address)], hydrated_targets()) for AddressSpecs
      (HydratedTargets, [BuildFileAddresses], [Get(HydratedTarget, Address)], hydrated_targets()) for BuildFileAddresses
      (HydratedTargets, [BuildFileAddresses], [Get(HydratedTarget, Address)], hydrated_targets()) for OwnersRequest
    Ambiguous rules to compute HydratedTargets with parameter types (AddressSpecs+BuildFileAddresses+HydratedTargets):
      (HydratedTargets, [BuildFileAddresses], [Get(HydratedTarget, Address)], hydrated_targets()) for AddressSpecs
      (HydratedTargets, [BuildFileAddresses], [Get(HydratedTarget, Address)], hydrated_targets()) for BuildFileAddresses
      Param(HydratedTargets)
    Ambiguous rules to compute HydratedTargets with parameter types (AddressSpecs+BuildFileAddresses+HydratedTargets+OptionsBootstrapper):
      (HydratedTargets, [BuildFileAddresses], [Get(HydratedTarget, Address)], hydrated_targets()) for AddressSpecs
      (HydratedTargets, [BuildFileAddresses], [Get(HydratedTarget, Address)], hydrated_targets()) for BuildFileAddresses
      Param(HydratedTargets)
    Ambiguous rules to compute HydratedTargets with parameter types (AddressSpecs+BuildFileAddresses+HydratedTargets+OptionsBootstrapper+OwnersRequest):
      (HydratedTargets, [BuildFileAddresses], [Get(HydratedTarget, Address)], hydrated_targets()) for AddressSpecs
      (HydratedTargets, [BuildFileAddresses], [Get(HydratedTarget, Address)], hydrated_targets()) for BuildFileAddresses
      (HydratedTargets, [BuildFileAddresses], [Get(HydratedTarget, Address)], hydrated_targets()) for OwnersRequest
      Param(HydratedTargets)
    Ambiguous rules to compute HydratedTargets with parameter types (AddressSpecs+BuildFileAddresses+HydratedTargets+OwnersRequest):
      (HydratedTargets, [BuildFileAddresses], [Get(HydratedTarget, Address)], hydrated_targets()) for AddressSpecs
      (HydratedTargets, [BuildFileAddresses], [Get(HydratedTarget, Address)], hydrated_targets()) for BuildFileAddresses
      (HydratedTargets, [BuildFileAddresses], [Get(HydratedTarget, Address)], hydrated_targets()) for OwnersRequest
      Param(HydratedTargets)
    Ambiguous rules to compute HydratedTargets with parameter types (AddressSpecs+BuildFileAddresses+OptionsBootstrapper):
      (HydratedTargets, [BuildFileAddresses], [Get(HydratedTarget, Address)], hydrated_targets()) for AddressSpecs
      (HydratedTargets, [BuildFileAddresses], [Get(HydratedTarget, Address)], hydrated_targets()) for BuildFileAddresses
    Ambiguous rules to compute HydratedTargets with parameter types (AddressSpecs+BuildFileAddresses+OptionsBootstrapper+OwnersRequest):
      (HydratedTargets, [BuildFileAddresses], [Get(HydratedTarget, Address)], hydrated_targets()) for AddressSpecs
      (HydratedTargets, [BuildFileAddresses], [Get(HydratedTarget, Address)], hydrated_targets()) for BuildFileAddresses
      (HydratedTargets, [BuildFileAddresses], [Get(HydratedTarget, Address)], hydrated_targets()) for OwnersRequest
    Ambiguous rules to compute HydratedTargets with parameter types (AddressSpecs+BuildFileAddresses+OwnersRequest):
      (HydratedTargets, [BuildFileAddresses], [Get(HydratedTarget, Address)], hydrated_targets()) for AddressSpecs
      (HydratedTargets, [BuildFileAddresses], [Get(HydratedTarget, Address)], hydrated_targets()) for BuildFileAddresses
      (HydratedTargets, [BuildFileAddresses], [Get(HydratedTarget, Address)], hydrated_targets()) for OwnersRequest
    Ambiguous rules to compute HydratedTargets with parameter types (AddressSpecs+Digest+HydratedTargets):
      (HydratedTargets, [BuildFileAddresses], [Get(HydratedTarget, Address)], hydrated_targets()) for AddressSpecs
      Param(HydratedTargets)
    Ambiguous rules to compute HydratedTargets with parameter types (AddressSpecs+Digest+HydratedTargets+OptionsBootstrapper):
      (HydratedTargets, [BuildFileAddresses], [Get(HydratedTarget, Address)], hydrated_targets()) for AddressSpecs
      Param(HydratedTargets)
    Ambiguous rules to compute HydratedTargets with parameter types (AddressSpecs+Digest+HydratedTargets+OptionsBootstrapper+OwnersRequest):
      (HydratedTargets, [BuildFileAddresses], [Get(HydratedTarget, Address)], hydrated_targets()) for AddressSpecs
      (HydratedTargets, [BuildFileAddresses], [Get(HydratedTarget, Address)], hydrated_targets()) for OwnersRequest
      Param(HydratedTargets)
    Ambiguous rules to compute HydratedTargets with parameter types (AddressSpecs+Digest+HydratedTargets+OwnersRequest):
      (HydratedTargets, [BuildFileAddresses], [Get(HydratedTarget, Address)], hydrated_targets()) for AddressSpecs
      (HydratedTargets, [BuildFileAddresses], [Get(HydratedTarget, Address)], hydrated_targets()) for OwnersRequest
      Param(HydratedTargets)
    Ambiguous rules to compute HydratedTargets with parameter types (AddressSpecs+Digest+OptionsBootstrapper+OwnersRequest):
      (HydratedTargets, [BuildFileAddresses], [Get(HydratedTarget, Address)], hydrated_targets()) for AddressSpecs
      (HydratedTargets, [BuildFileAddresses], [Get(HydratedTarget, Address)], hydrated_targets()) for OwnersRequest
    Ambiguous rules to compute HydratedTargets with parameter types (AddressSpecs+Digest+OwnersRequest):
      (HydratedTargets, [BuildFileAddresses], [Get(HydratedTarget, Address)], hydrated_targets()) for AddressSpecs
      (HydratedTargets, [BuildFileAddresses], [Get(HydratedTarget, Address)], hydrated_targets()) for OwnersRequest
    Ambiguous rules to compute HydratedTargets with parameter types (AddressSpecs+HydratedTargets):
      (HydratedTargets, [BuildFileAddresses], [Get(HydratedTarget, Address)], hydrated_targets()) for AddressSpecs
      Param(HydratedTargets)
    Ambiguous rules to compute HydratedTargets with parameter types (AddressSpecs+HydratedTargets+OptionsBootstrapper):
      (HydratedTargets, [BuildFileAddresses], [Get(HydratedTarget, Address)], hydrated_targets()) for AddressSpecs
      Param(HydratedTargets)
    Ambiguous rules to compute HydratedTargets with parameter types (AddressSpecs+HydratedTargets+OptionsBootstrapper+OwnersRequest):
      (HydratedTargets, [BuildFileAddresses], [Get(HydratedTarget, Address)], hydrated_targets()) for AddressSpecs
      (HydratedTargets, [BuildFileAddresses], [Get(HydratedTarget, Address)], hydrated_targets()) for OwnersRequest
      Param(HydratedTargets)
    Ambiguous rules to compute HydratedTargets with parameter types (AddressSpecs+HydratedTargets+OwnersRequest):
      (HydratedTargets, [BuildFileAddresses], [Get(HydratedTarget, Address)], hydrated_targets()) for AddressSpecs
      (HydratedTargets, [BuildFileAddresses], [Get(HydratedTarget, Address)], hydrated_targets()) for OwnersRequest
      Param(HydratedTargets)
    Ambiguous rules to compute HydratedTargets with parameter types (AddressSpecs+OptionsBootstrapper+OwnersRequest):
      (HydratedTargets, [BuildFileAddresses], [Get(HydratedTarget, Address)], hydrated_targets()) for AddressSpecs
      (HydratedTargets, [BuildFileAddresses], [Get(HydratedTarget, Address)], hydrated_targets()) for OwnersRequest
    Ambiguous rules to compute HydratedTargets with parameter types (AddressSpecs+OwnersRequest):
      (HydratedTargets, [BuildFileAddresses], [Get(HydratedTarget, Address)], hydrated_targets()) for AddressSpecs
      (HydratedTargets, [BuildFileAddresses], [Get(HydratedTarget, Address)], hydrated_targets()) for OwnersRequest
    Ambiguous rules to compute HydratedTargets with parameter types (BuildFileAddresses+Digest+HydratedTargets):
      (HydratedTargets, [BuildFileAddresses], [Get(HydratedTarget, Address)], hydrated_targets()) for BuildFileAddresses
      Param(HydratedTargets)
    Ambiguous rules to compute HydratedTargets with parameter types (BuildFileAddresses+Digest+HydratedTargets+OptionsBootstrapper):
      (HydratedTargets, [BuildFileAddresses], [Get(HydratedTarget, Address)], hydrated_targets()) for BuildFileAddresses
      Param(HydratedTargets)
    Ambiguous rules to compute HydratedTargets with parameter types (BuildFileAddresses+Digest+HydratedTargets+OptionsBootstrapper+OwnersRequest):
      (HydratedTargets, [BuildFileAddresses], [Get(HydratedTarget, Address)], hydrated_targets()) for BuildFileAddresses
      (HydratedTargets, [BuildFileAddresses], [Get(HydratedTarget, Address)], hydrated_targets()) for OwnersRequest
      Param(HydratedTargets)
    Ambiguous rules to compute HydratedTargets with parameter types (BuildFileAddresses+Digest+HydratedTargets+OwnersRequest):
      (HydratedTargets, [BuildFileAddresses], [Get(HydratedTarget, Address)], hydrated_targets()) for BuildFileAddresses
      (HydratedTargets, [BuildFileAddresses], [Get(HydratedTarget, Address)], hydrated_targets()) for OwnersRequest
      Param(HydratedTargets)
    Ambiguous rules to compute HydratedTargets with parameter types (BuildFileAddresses+Digest+OptionsBootstrapper+OwnersRequest):
      (HydratedTargets, [BuildFileAddresses], [Get(HydratedTarget, Address)], hydrated_targets()) for BuildFileAddresses
      (HydratedTargets, [BuildFileAddresses], [Get(HydratedTarget, Address)], hydrated_targets()) for OwnersRequest
    Ambiguous rules to compute HydratedTargets with parameter types (BuildFileAddresses+Digest+OwnersRequest):
      (HydratedTargets, [BuildFileAddresses], [Get(HydratedTarget, Address)], hydrated_targets()) for BuildFileAddresses
      (HydratedTargets, [BuildFileAddresses], [Get(HydratedTarget, Address)], hydrated_targets()) for OwnersRequest
    Ambiguous rules to compute HydratedTargets with parameter types (BuildFileAddresses+HydratedTargets):
      (HydratedTargets, [BuildFileAddresses], [Get(HydratedTarget, Address)], hydrated_targets()) for BuildFileAddresses
      Param(HydratedTargets)
    Ambiguous rules to compute HydratedTargets with parameter types (BuildFileAddresses+HydratedTargets+OptionsBootstrapper):
      (HydratedTargets, [BuildFileAddresses], [Get(HydratedTarget, Address)], hydrated_targets()) for BuildFileAddresses
      Param(HydratedTargets)
    Ambiguous rules to compute HydratedTargets with parameter types (BuildFileAddresses+HydratedTargets+OptionsBootstrapper+OwnersRequest):
      (HydratedTargets, [BuildFileAddresses], [Get(HydratedTarget, Address)], hydrated_targets()) for BuildFileAddresses
      (HydratedTargets, [BuildFileAddresses], [Get(HydratedTarget, Address)], hydrated_targets()) for OwnersRequest
      Param(HydratedTargets)
    Ambiguous rules to compute HydratedTargets with parameter types (BuildFileAddresses+HydratedTargets+OwnersRequest):
      (HydratedTargets, [BuildFileAddresses], [Get(HydratedTarget, Address)], hydrated_targets()) for BuildFileAddresses
      (HydratedTargets, [BuildFileAddresses], [Get(HydratedTarget, Address)], hydrated_targets()) for OwnersRequest
      Param(HydratedTargets)
    Ambiguous rules to compute HydratedTargets with parameter types (BuildFileAddresses+OptionsBootstrapper+OwnersRequest):
      (HydratedTargets, [BuildFileAddresses], [Get(HydratedTarget, Address)], hydrated_targets()) for BuildFileAddresses
      (HydratedTargets, [BuildFileAddresses], [Get(HydratedTarget, Address)], hydrated_targets()) for OwnersRequest
    Ambiguous rules to compute HydratedTargets with parameter types (BuildFileAddresses+OwnersRequest):
      (HydratedTargets, [BuildFileAddresses], [Get(HydratedTarget, Address)], hydrated_targets()) for BuildFileAddresses
      (HydratedTargets, [BuildFileAddresses], [Get(HydratedTarget, Address)], hydrated_targets()) for OwnersRequest
    Ambiguous rules to compute HydratedTargets with parameter types (Digest+HydratedTargets+OptionsBootstrapper+OwnersRequest):
      (HydratedTargets, [BuildFileAddresses], [Get(HydratedTarget, Address)], hydrated_targets()) for OwnersRequest
      Param(HydratedTargets)
    Ambiguous rules to compute HydratedTargets with parameter types (Digest+HydratedTargets+OwnersRequest):
      (HydratedTargets, [BuildFileAddresses], [Get(HydratedTarget, Address)], hydrated_targets()) for OwnersRequest
      Param(HydratedTargets)
    Ambiguous rules to compute HydratedTargets with parameter types (HydratedTargets+OptionsBootstrapper+OwnersRequest):
      (HydratedTargets, [BuildFileAddresses], [Get(HydratedTarget, Address)], hydrated_targets()) for OwnersRequest
      Param(HydratedTargets)
    Ambiguous rules to compute HydratedTargets with parameter types (HydratedTargets+OwnersRequest):
      (HydratedTargets, [BuildFileAddresses], [Get(HydratedTarget, Address)], hydrated_targets()) for OwnersRequest
      Param(HydratedTargets)
  (CreatedBinary, [HydratedTarget], [Get(CreatedBinary, PythonBinaryAdaptor)], coordinator_of_binaries()):

I can't figure it out if anyone has any tips.

@stuhood
Copy link
Member

stuhood commented Jan 9, 2020

Possibly another flavor of #7710. Does it fail before running, or only in the test?

@Eric-Arellano
Copy link
Contributor Author

It fails with simply calling ./pants.

@Eric-Arellano
Copy link
Contributor Author

Closing until we fix #7710.

@Eric-Arellano Eric-Arellano deleted the fix-inject-init branch January 24, 2020 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Eric-Arellano @stuhood