Change RscCompile --workflow-override flag to --scala-workflow-override #8575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wiwa
changed the title
stuhood
approved these changes
Nov 6, 2019
src/python/pants/backend/jvm/tasks/jvm_compile/rsc/rsc_compile.py
Outdated
Show resolved
Hide resolved
wiwa
force-pushed
the
b/workflow-override-scala
branch
from
8788d3d
to
8584838
Compare
stuhood
force-pushed
the
b/workflow-override-scala
branch
from
8584838
to
0d9c476
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
RscCompile's--workflow-overrideflag effect is incorrect due to currentlack of Java support. Instead of overriding the workflow of all targets, only
Scala targets should be affected.
Solution
Rename the flag and have it only affect the
workflowoption of Scala targets.Result
Fixes the incorrectly-implemented
--workflow-overrideflag.