Fix error when uploading stats to stats storage #8233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
illicitonion
reviewed
Sep 2, 2019
cattibrie
force-pushed
the
etyurina/fix_error_in_uploading_to_buildstats
branch
from
e977cc7
to
cb6a5e7
Compare
This was referenced Sep 3, 2019
blorente
pushed a commit
that referenced
this pull request
Sep 4, 2019
### Problem Stats are not uploaded to stats storage because the size of the request is too big. Workunit information from the engine is passed to python as a part of the metrics and are recorded as a part of pantsd_stats. ### Solution Workunit info from the engine is not passed to pantsd_stats.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Stats are not uploaded to stats storage because the size of the request is too big.
Workunit information from the engine is passed to python as a part of the metrics and are recorded as a part of pantsd_stats.
Solution
Workunit info from the engine is not passed to pantsd_stats.