Add a header X-B3-Flags: 1 to the request to Zipkin server
#8223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blorente
requested review from
illicitonion,
stuhood,
blorente and
pierrechevalier83
blorente
approved these changes
Aug 29, 2019
stuhood
reviewed
Aug 29, 2019
| @@ -49,6 +49,7 @@ def send(self, payload): | |||
| args = ['curl', '-v', | |||
| '-X', 'POST', | |||
| '-H', 'Content-Type: application/json', | |||
| '-H', 'X-B3-Flags: 1', | |||
There was a problem hiding this comment.
This should probably have a comment that includes some of the PR description in order to make things easier for the reader. It's not a particularly self-explanatory flag.
pierrechevalier83
approved these changes
Aug 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a header
X-B3-Flags: 1to the request to Zipkin server. It is a debug flag that ensures that the trace will be retained on the server side.The decision to sample is made on the client side by setting
--reporting-zipkin-sample-rate.