Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support using @dataclass for engine params #8181

Merged
merged 8 commits into from
Oct 20, 2019
Merged

support using @dataclass for engine params #8181

merged 8 commits into from
Oct 20, 2019

Commits on Oct 18, 2019

  1. require @DataClass to set frozen=True 

    deprecate datatype()!

add test for rules with python dataclasses!

remove all the conversion to custom datatypes!!!

fix the readme!!!

ensure @DataClass types have frozen=True when used in the engine

clarify mypy compatibility

don't display deprecation warnings in CI

bump deprecation version

fix import ordering

make lint and unit tests pass

fix mypy line number

remove deprecation warning ignore filter in travis

fix weird mypy errors

try to see if removing the deprecation stops the timeouts!

fix test failure and uncomment deprecation!
    @cosmicexplorer
    cosmicexplorer committed Oct 18, 2019
    Configuration menu
    Copy the full SHA
    ab9bcdb View commit details
    Browse the repository at this point in the history

  2. mention @frozen_after_init in the engine README

    @cosmicexplorer
    cosmicexplorer committed Oct 18, 2019
    Configuration menu
    Copy the full SHA
    23c191b View commit details
    Browse the repository at this point in the history

  3. remove mypy testing

    @cosmicexplorer
    cosmicexplorer committed Oct 18, 2019
    Configuration menu
    Copy the full SHA
    2bd83f4 View commit details
    Browse the repository at this point in the history

  4. Apply suggestions from code review 

    Co-Authored-By: Eric Arellano <ericarellano@me.com>
    @cosmicexplorer @Eric-Arellano
    cosmicexplorer and Eric-Arellano committed Oct 18, 2019
    Configuration menu
    Copy the full SHA
    112fd19 View commit details
    Browse the repository at this point in the history

  5. use better rule type declaration method!

    @cosmicexplorer
    cosmicexplorer committed Oct 18, 2019
    Configuration menu
    Copy the full SHA
    9e5b70c View commit details
    Browse the repository at this point in the history

  6. update deprecation warning settings and push deprecation date for dat… 

    …atype()
    @cosmicexplorer
    cosmicexplorer committed Oct 18, 2019
    Configuration menu
    Copy the full SHA
    f2a4a4d View commit details
    Browse the repository at this point in the history

  7. add testing for @frozen_after_init

    @cosmicexplorer
    cosmicexplorer committed Oct 18, 2019
    Configuration menu
    Copy the full SHA
    b791a0d View commit details
    Browse the repository at this point in the history

  8. remove duplicated fields

    @cosmicexplorer
    cosmicexplorer committed Oct 18, 2019
    Configuration menu
    Copy the full SHA
    a5ee2c2 View commit details
    Browse the repository at this point in the history