Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pin tensorflow example to 1.13.1 #8135

Merged

Conversation

cosmicexplorer
Copy link
Contributor

Problem

#8099 is failing in the lint shard due to a failing link for the C++ code in the tensorflow custom operator example. This is because tensorflow 1.14 begins to use a symlink for libtensorflow_framework.so, pointing to another file in the same directory, and we haven't pinned the tensorflow dependency to 1.13.1.

Solution

  • Pin the tensorflow dependency to 1.13.1 until we can support 1.14.

Result

Native compiles and linking succeed!

Copy link
Contributor

@wisechengyi wisechengyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Danny!

@wisechengyi wisechengyi merged commit d316e18 into pantsbuild:master Aug 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants