Remove --resolve-jvm-capture-snapshots and --pytest-run-options #8123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blorente
requested review from
stuhood,
jsirois,
illicitonion and
cosmicexplorer
|
Looks like we need to fix the version number too. I'll pull that in here. |
|
The test timeouts here are (mostly) addressed by #8126: will merge if I see only timeouts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Merged #8120 without letting travis finish.
That PR bumped the version, and that made two options deprecated. This means that almost all integration test shards fail in master. (e.g. https://travis-ci.org/pantsbuild/pants/jobs/565035360)
Solution
Remove both options, and their usages.
Result
Hopefully travis should be green. I tested the failing shards locally and they seem to work so far.