Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move MyPy from isolated goal into 'lint' goal and add MyPy whitelist/opt-in type checking #8099
Move MyPy from isolated goal into 'lint' goal and add MyPy whitelist/opt-in type checking #8099
Changes from 4 commits
8b75dec
ca47558
73c24fd
6822729
bca96d2
60a8638
d908bee
c758e59
2186531
80c666b
0cb69f4
b45a94d
dff9175
27adf2b
3cfb3fa
f8e90c1
dd9909a
90cd103
a3c163a
3f41b85
f70ac76
1049a84
7282342
27ad8a5
98dd205
2d72f08
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this message might be better moved inline. Out of context, I was confused.
One possibility: end the sentence at line 34 and then line 35 has parentheses with this message.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See above about reverting this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I totally agree, a lot of these changes were to subvert a failing lint shard in ci, but this way I don't think mypy works as intended anymore.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mypy isn't used much in pants, so I think we're sticking with this for now. We should eventually find a way to avoid the c++ resolving issue(s).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that we do actually need to configure this right now.
If we were going to temporarily stop configuring it, the right way to do that would be with a
TODO
here that disables it and points to a ticket for re-enabling it. But as Eric said, I don't think we should do that without more discussion.