Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle blank description in _print_goals_help #8088

Merged
merged 1 commit into from
Sep 26, 2019

Conversation

gshuflin
Copy link
Contributor

If there is no description for a scope_info goal, print out a message to this
effect associated with that goal rather than just a blank line.

@jsirois
Copy link
Contributor

jsirois commented Aug 5, 2019

This will probably need re-base to re-trigger a full CI and get past the current dup binary issues.

@gshuflin gshuflin force-pushed the description_fix branch 3 times, most recently from 2df48be to d8b0103 Compare August 15, 2019 16:44
@jsirois
Copy link
Contributor

jsirois commented Aug 19, 2019

I'm babysitting the red - apparently flake / timeout - shards. Will merge on green.

@jsirois
Copy link
Contributor

jsirois commented Aug 19, 2019

@gshuflin this will need another rebase to kick off a fresh CI, getting:

...
2.19s$ ./build-support/bin/get_ci_bootstrapped_pants_pex.sh ${BOOTSTRAPPED_PEX_BUCKET} ${BOOTSTRAPPED_PEX_KEY_PREFIX}.${BOOTSTRAPPED_PEX_KEY_SUFFIX}
  
Error: Found 0 versions for s3://ci-public.pantsbuild.org/25831/572381372/pants.pex.py36.osx
The command "./build-support/bin/get_ci_bootstrapped_pants_pex.sh ${BOOTSTRAPPED_PEX_BUCKET} ${BOOTSTRAPPED_PEX_KEY_PREFIX}.${BOOTSTRAPPED_PEX_KEY_SUFFIX}
  " failed and exited with 1 during .
...

@gshuflin gshuflin force-pushed the description_fix branch 3 times, most recently from 81f2a69 to e67ea42 Compare September 25, 2019 23:35
If there is no description for a scope_info goal, print out a message to this
effect associated with that goal rather than just a blank line.
@jsirois jsirois merged commit e6fe395 into pantsbuild:master Sep 26, 2019
@gshuflin gshuflin deleted the description_fix branch September 26, 2019 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants