Fix PytestRun to honor user conftest.py plugins.
#7784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously codebases that leveraged pytest's `conftest.py` support could fail when tested with pants test in various situations. This was ultimately because we injected out own `conftest.py` to register our custom pytest plugins and plugin discovery of `conftest.py` plugins is brittle. We avoid the brittleness by moving our plugin into a `sys.path` module activated with `-p` fixing a previously failing test added in `test_conftests_discovery_with_coverage`.
jsirois
commented
May 21, 2019
| import pytest | ||
|
|
||
|
|
||
| class NodeRenamerPlugin(object): |
There was a problem hiding this comment.
NB: This is mainly a move from _get_conftest_content on the LHS.
jsirois
commented
May 21, 2019
| item._nodeid = real_nodeid | ||
|
|
||
|
|
||
| class ShardingPlugin(object): |
There was a problem hiding this comment.
NB: This is mainly a move from _get_shard_conftest_content on the LHS.
asherf
approved these changes
May 21, 2019
|
I'm going to submit but I'll circle back if there is any further feedback. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously codebases that leveraged pytest's
conftest.pysupport couldfail when tested with
./pants testin various situations. This wasultimately because we injected our own
conftest.pyto register ourcustom pytest plugins and plugin discovery of
conftest.pyplugins isbrittle. We avoid the brittleness by moving our plugin into a
sys.pathmodule activated with
-pfixing a previously failing test added intest_conftests_discovery_with_coverage.