Memoize graph walks on Context #7758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsirois
approved these changes
May 18, 2019
stuhood
force-pushed
the
stuhood/memoize-graph-walks
branch
from
74fbc91
to
40fc18e
Compare
stuhood
added a commit
that referenced
this pull request
May 19, 2019
### Problem In profiling of noop runs, `Context.targets(predicate=..)` was taking up a surprising amount of time due to not being memoized. While investigating, I also noticed that `MutableBuildGraph` was made unnecessary via #7243 and others. ### Solution Remove `MutableBuildGraph`, inline one method that was unnecessarily abstract into `BuildGraph`, and then add support for a callback that can be used to invalidate caches of graph consumption. As the comments point out, we hope to eliminate mutability entirely for this usecase in the future. ### Result A 17% speedup for noop runs of larger targets.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
In profiling of noop runs,
Context.targets(predicate=..)was taking up a surprising amount of time due to not being memoized. While investigating, I also noticed thatMutableBuildGraphwas made unnecessary via #7243 and others.Solution
Remove
MutableBuildGraph, inline one method that was unnecessarily abstract intoBuildGraph, and then add support for a callback that can be used to invalidate caches of graph consumption. As the comments point out, we hope to eliminate mutability entirely for this usecase in the future.Result
A 17% speedup for noop runs of larger targets.