Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for v2-only goals, and replace list with a @console_rule #6880

Merged
merged 8 commits into from
Apr 21, 2019
Merged

Add support for v2-only goals, and replace list with a @console_rule #6880

merged 8 commits into from
Apr 21, 2019

Commits on Apr 20, 2019

  1. Require a new Optionable subclass Goal as the first argument to `@c… 

    …onsole_rule` in order to provide help, options, and a CLI scope.
    @stuhood
    stuhood committed Apr 20, 2019
    Configuration menu
    Copy the full SHA
    201980d View commit details
    Browse the repository at this point in the history

  2. Run unambiguous goals regardless of the --v1 and --v2 settings, a… 

    …nd dedupe scope registrations.
    @stuhood
    stuhood committed Apr 20, 2019
    Configuration menu
    Copy the full SHA
    ef86a50 View commit details
    Browse the repository at this point in the history

  3. Remove excess wrapping from Specs creation to fix assertion error on … 

    …empty specs.
    @stuhood
    stuhood committed Apr 20, 2019
    Configuration menu
    Copy the full SHA
    10fd0d8 View commit details
    Browse the repository at this point in the history

  4. Port ListTargets test to a new ConsoleRuleTestBase base class.

    @stuhood
    stuhood committed Apr 20, 2019
    Configuration menu
    Copy the full SHA
    f69c6f4 View commit details
    Browse the repository at this point in the history

  5. Backfill existing options, by: 1) optionally add a deprecated depende… 

    …ncy on a scoped `CacheSetup` instance, 2) adding a `LineOriented` mixin for `Goal`.
    @stuhood
    stuhood committed Apr 20, 2019
    Configuration menu
    Copy the full SHA
    0d32b84 View commit details
    Browse the repository at this point in the history

  6. Overhaul Goal and @console_rule such that @console_rules actually pro… 

    …duce an instance of their Goal type, and options are provided by an inner class of Goal.
    @stuhood
    stuhood committed Apr 20, 2019
    Configuration menu
    Copy the full SHA
    e40fe1e View commit details
    Browse the repository at this point in the history

  7. Test fixes: ensure that RunTracker runs are created, and make v1/v2 e… 

    …xits more uniform.
    @stuhood
    stuhood committed Apr 20, 2019
    Configuration menu
    Copy the full SHA
    68165cd View commit details
    Browse the repository at this point in the history

  8. line_oriented as classmethod

    @stuhood
    stuhood committed Apr 20, 2019
    Configuration menu
    Copy the full SHA
    6af8b78 View commit details
    Browse the repository at this point in the history