Add the ability to consume scoped Options from @rules #6872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Commits should be useful to review independently. |
wisechengyi
approved these changes
Dec 6, 2018
…` re-parses bootstrap options anyway.
stuhood
force-pushed
the
stuhood/option-input-datatypes
branch
from
7872458 to
2bd4f6d
Compare
|
This no longer depends on #6871. |
…ptionsBootstrapper.
… mid-level integration tests.
stuhood
force-pushed
the
stuhood/option-input-datatypes
branch
from
2bd4f6d to
5569e33
Compare
ity
approved these changes
Dec 6, 2018
| ) | ||
|
|
||
| def register_global(*args, **kwargs): | ||
| ## Only use of Options.register? |
There was a problem hiding this comment.
Was there before: just moved.
|
Have seen #6879 a few times today, and restarting shards has fixed it. Merging. |
stuhood
pushed a commit
that referenced
this pull request
Jan 4, 2019
### Problem #6872 laid groundwork for consuming `(Scoped)Options` from `@rules`, but did not actually expose a facility for a `@(console_)rule` to consume a `Subsystem`. ### Solution Expose `ScopedOptions` parsing to `@console_rules`, and add a helper method that creates an `@rule` to construct a `Subsystem`. Finally, use this facility to have `v2` `list` consume a `Subsystem` that holds options that define (most) of the behaviour that would allow it to replace the `Task`/`v1` implementation of `./pants list`. ### Result `@rules` and `@console_rules` can consume `Subsystems`. This is a prerequisite for #6880, which will build atop this facility to fully support `v2`-only goals, and replace `v1` `list` with `v2` `list`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
As described in #5869, we need a way to consume
Optionsin the new engine in order to provide access toSubsystemsin@rules.Solution
Convert
OptionsBootstrapperandConfigintodatatypes in order to give them useful eq/hash implementations.Then, modify the
@rulesthat were added in #5889 to consume theParamsAPI added in #6871 and expose aScopedOptionswrapper around the set of options for aScope.Result
@rulescan consumeScopedOptions, although there should probably be built-in rules that can consumeScopedOptionsto createSubsystems. Nonetheless, let's say that this "fixes #5869", and open a followup for actually exposingSubsystemsto@rulesin a generic way.