-
-
Notifications
You must be signed in to change notification settings - Fork 632
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare a noop release for 1.9.0rc1. #6204
Prepare a noop release for 1.9.0rc1. #6204
Conversation
src/python/pants/notes/master.rst
Outdated
@@ -4,7 +4,12 @@ Master Pre-Releases | |||
This document describes ``dev`` releases which occur weekly from master, and which do | |||
not undergo the vetting associated with ``stable`` releases. | |||
|
|||
1.9.0rc0 (07/18/2018) | |||
1.9.0rc1 (07/20/2018) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This won't be release from master, so no edits needed in master.rst
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed the 1.9.0rc1
entry from master.rst
in d3b5d9d!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did we change the process recently? iirc, the notes still needs to be on master.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh nvm. master.rst
doesn't need to change.
src/python/pants/notes/master.rst
Outdated
1.9.0rc1 (07/20/2018) | ||
--------------------- | ||
|
||
*1.9.0rc0 failed due to a pypi error -- see `Issue 6192 <https://github.com/pantsbuild/pants/issues/6192>`.* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure how that renders, but using the normal format would be fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in 8ac01f1!
src/python/pants/VERSION
Outdated
@@ -1 +1 @@ | |||
1.9.0rc0 | |||
1.9.0rc1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please leave this unchanged. This PR would land on master, so the diff to change version to 1.9.0rc1
should land on the 1.9.x branch separately.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it. I will make that change to the 1.9.x
branch, which I will create now. The change was reverted in d46f679.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whoops. Yep, that too. https://www.pantsbuild.org/release.html#preparing-a-release-from-a-stable-branch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Danny!
### Problem Trying to release `1.9.0rc0` failed, and pypi won't accept another release to the same version. #6192 will have more information about what happened here after we can get this release out. ### Solution Make a noop release for `1.9.0rc1`. ### Result We finally have a release candidate for 1.9.0. I plan to fast-follow with a hotfix release `rc2` containing the changes from both #6201 and #6179, as these both describe bugged functionality that would make it very difficult to use `python_dist()` and the new C/C++ targets.
### Problem Trying to release `1.9.0rc0` failed, and pypi won't accept another release to the same version. pantsbuild#6192 will have more information about what happened here after we can get this release out. ### Solution Make a noop release for `1.9.0rc1`. ### Result We finally have a release candidate for 1.9.0. I plan to fast-follow with a hotfix release `rc2` containing the changes from both pantsbuild#6201 and pantsbuild#6179, as these both describe bugged functionality that would make it very difficult to use `python_dist()` and the new C/C++ targets.
Problem
Trying to release
1.9.0rc0
failed, and pypi won't accept another release to the same version. #6192 will have more information about what happened here after we can get this release out.Solution
Make a noop release for
1.9.0rc1
.Result
We finally have a release candidate for 1.9.0. I plan to fast-follow with a hotfix release
rc2
containing the changes from both #6201 and #6179, as these both describe bugged functionality that would make it very difficult to usepython_dist()
and the new C/C++ targets.