Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release Pants as a pex. #6014

Merged
merged 1 commit into from
Jun 25, 2018
Merged

Release Pants as a pex. #6014

merged 1 commit into from
Jun 25, 2018

Conversation

jsirois
Copy link
Contributor

@jsirois jsirois commented Jun 24, 2018

This adds release automation of a Pants pex to our Travis CI job when
run against a release_* tag. There is more to be done to consume the pex
in the setup script we point users to, but the actual release should now
be covered.

Fixes #4896

This adds release automation of a Pants pex to our Travis CI job when
run against a release_* tag. There is more to be done to consume the pex
in the setup script we point users to, but the actual release should now
be covered.

Fixes pantsbuild#4896
@jsirois jsirois merged commit c5a46e9 into pantsbuild:master Jun 25, 2018
@jsirois jsirois deleted the issues/4896 branch June 25, 2018 13:35
Copy link
Member

@kwlzn kwlzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

Copy link
Member

@stuhood stuhood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this!

file: dist/deploy/pex/*
skip_cleanup: true
on:
# We only release a pex for Pants releases, which are tagged.
Copy link
Member

@stuhood stuhood Jun 25, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, while only building pexes for tags should reduce storage costs, Twitter does currently rely on the fact that travis publishes wheels for "all origin branch shas", in that we consume nightly/master wheels for a nightly smoketest.

I think that the storage costs for pexes should be relatively small, and that most of the cost would be from people actually fetching them. @benjyw : does that sound right?

If so, it would be good to ship pexes for all branches (but not PRs).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 things:

  1. This deploys using github releases which only work for tags. I think this is a good thing for our public releases - pypi and github releases are standard discoverable things, an s3 bucket isn't as much.
  2. Cache ./pants bootstrapping in CI using stages #6016 will require storing pexes for all shas temporarily in S3. This will need a new bucket with a TTL attached to auto-purge. Wheels can get moved there too.

I'd like to defer the per-branch bit until work on point 2.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, works for me. Thanks.

As long as the -p flag continues to work, Twitter can wait to migrate to the new mechanism.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is true that our costs are 99% bandwidth, not storage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants