Deprecate legacy default sources API #5987
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuhood
requested changes
Jun 19, 2018
| lambda: True, | ||
| '1.10.0.dev0', | ||
| ('Specifying default sources on Targets is deprecated, and now takes a slow path. ' | ||
| 'Instead, class {} should have a TargetAdaptor installed specifying default sources to ' |
There was a problem hiding this comment.
I don't think there is a way for a plugin author to do this, since TargetAdaptors are (intentionally) not exposed as an extension point right now... see #3560 (mentioned in src/python/pants/init/engine_initializer.py) and #4535 about that.
I think that in order to do this, we'd need to actually expose TargetAdaptor... and it's not clear how to do that. A few options:
- doing it as a static/cls method of
Target - requiring that
Targettypes that need to be constructed with aTargetAdaptorsubclass other than the default need to installdef ruleswith a particular shape - ?
|
Sent out #5989 which is probably better |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead, fill in defaults during the engine parsing phase.
This means that default sources are eager parsed in parallel alongside the rest of BUILD file parsing, rather than lazily done synchronously later on.