Robustify go_protobuf_library #5887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that `go_protobuf_library` has been added, I found a couple minor issues in real-world use-cases. Not all protobuf IDL files contain a go namespace, so we should fall back to the package. Also, we should use the go namespace as-is in the path names as sometimes there are path elements that contain a `.` (e.g.: `github.com`) which is a Go thing.
stuhood
approved these changes
Jun 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that
go_protobuf_libraryhas been added, I found a couple minor issues in real-world use-cases. Not all protobuf IDL files contain a Go namespace, so we should fall back to the package. Also, we should use the Go namespace as-is in the path names as sometimes there are path elements that contain a.(e.g.:github.com) which is a Go thing.