-
-
Notifications
You must be signed in to change notification settings - Fork 632
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow alternate binaries download urls generation and convert GoDistribution and LLVM subsystems to use it #5780
Merged
stuhood
merged 62 commits into
pantsbuild:master
from
cosmicexplorer:fix-binaries-bandwidth-s3
May 14, 2018
Merged
Changes from 1 commit
Commits
Show all changes
62 commits
Select commit
Hold shift + click to select a range
3a64c8d
decouple full url list generation from the fetch method
cosmicexplorer c95187b
add urls optional arg for custom urls
cosmicexplorer 937fc58
download go from the google site with the new urls method
cosmicexplorer d7e2235
add txz archiver
cosmicexplorer 289618f
demonstrate platform-specific conditionals in clang.py
cosmicexplorer 26a232b
switch go to download the official distribution
cosmicexplorer a2fc3bd
remove some cruft
cosmicexplorer cef7e9d
support xz decompression
cosmicexplorer 6a888db
switch llvm to use the official binary distributions
cosmicexplorer dea596f
remove stray thought
cosmicexplorer 24a9688
remove unused import
cosmicexplorer 22b3d94
fix docstring and error on archive creation for xz
cosmicexplorer 888289d
fix option names
cosmicexplorer c02984f
add extra line for lint
cosmicexplorer d6c6b3c
the magic of TODOs
cosmicexplorer b26651f
turn lzma.LZMAFile() into a contextmanager
cosmicexplorer d4490b4
refactor llvm.py
cosmicexplorer 4a62557
remove gcc subsystem
cosmicexplorer 9454ece
refactor the default urls into a classmethod
cosmicexplorer 14d1cda
isolate the path and see what travis says
cosmicexplorer b2b4866
add back archive_extensions
cosmicexplorer 9ee6c3a
deprecate pants.archive.archiver()
cosmicexplorer 13adbeb
make it more ergonomic to use 3rdparty dists
cosmicexplorer 5d705fd
add binary tool testing
cosmicexplorer 3c2608a
fix lint errors
cosmicexplorer 2860f4c
add entries to setup.py execution environment
cosmicexplorer b8b6ce9
unremove gcc
cosmicexplorer 1944907
remove _make_tar_archiver()
cosmicexplorer 3d2651d
Clang -> LLVM in native_toolchain.py
cosmicexplorer fc92529
default to gcc on travis until we can get this mess sorted out
cosmicexplorer cb35dc3
remove explicit LDSHARED
cosmicexplorer b29bca3
add back OrderedSet because the inline comment still applies
cosmicexplorer 43b1994
skip outdated native toolchain subsystem unit test
cosmicexplorer 5b3251e
add xz to the relevant travis shards
cosmicexplorer ad852dd
fix the ci failures for real hopefully
cosmicexplorer 774d277
i heard you liked binary tools so i put a binary tool in your binary …
cosmicexplorer c6dc4aa
fix reading mode so we decompress and extract in one go instead of ma…
cosmicexplorer ac57d6b
split up BinaryUtilPrivate and make path_by_id a global option
cosmicexplorer 977ce29
iterate on the data flow in BinaryUtil to make it testable (and test it)
cosmicexplorer f4cf5ce
fix a pretty obvious oversight
cosmicexplorer 1ca2444
lint fixes
cosmicexplorer a5557be
isort.sh -f
cosmicexplorer e2cc759
Merge branch 'master' into fix-binaries-bandwidth-s3
cosmicexplorer 1bdc88f
fix the panstd ci failures and add todo
cosmicexplorer 65b2a07
Use custom fork of grpcio-compiler (#5810)
illicitonion a4faf38
Merge branch 'master' into fix-binaries-bandwidth-s3
cosmicexplorer 796d5e2
provide LD_LIBRARY_PATH from the extracted archive when invoking xz
cosmicexplorer 23b2536
fix remaining ci failure
cosmicexplorer 3f99875
add some docstrings and add the --force-baseurls bootstrap option
cosmicexplorer 9b6a4c5
add some docstrings, improve some error messages, and cull old TODOS
cosmicexplorer 370fef0
fix the --force-baseurls option and make the LLVM BinaryTool work wit…
cosmicexplorer 3b90467
describe the url_generator(self) method
cosmicexplorer 1af5657
expand xz docstring
cosmicexplorer 873d037
cleanup
cosmicexplorer dfb677b
add force_baseurls param to other BinaryUtilPrivate creation and add …
cosmicexplorer 8ec8c9d
fill out a lot of docstrings
cosmicexplorer b1119a5
fix up some docstrings
cosmicexplorer 8ff8f63
advance the docstrings further
cosmicexplorer c8bb85d
change --force-baseurls to --allow-external-binary-tool-downloads
cosmicexplorer e109d71
move external url generator tests in the file
cosmicexplorer 8323c72
fix import sort order
cosmicexplorer 55e6fb3
transplant PR comment from benjy directly into the source
cosmicexplorer File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -164,11 +164,10 @@ def register_bootstrap_options(cls, register): | |
help=("Maps output of uname for a machine to a binary search path: " | ||
"(sysname, id) -> (os, arch), e.g. {('darwin', '15'): ('mac', '10.11'), " | ||
"('linux', 'arm32'): ('linux', 'arm32')}.")) | ||
# BinaryTool options. | ||
register('--force-baseurls', type=bool, default=False, advanced=True, | ||
help="Force BinaryTool subclasses to download from urls generated from " | ||
"--binaries-baseurls, even if the tool has a custom url generator. " | ||
"This can be necessary if using Pants in an environment which cannot " | ||
register('--allow-external-binary-tool-downloads', type=bool, default=True, advanced=True, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Now the name and the help text mesh together nicely! There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Totally agree! |
||
help="If False, require BinaryTool subclasses to download their contents from urls " | ||
"generated from --binaries-baseurls, even if the tool has an external url " | ||
"generator. This can be necessary if using Pants in an environment which cannot " | ||
"contact the wider Internet.") | ||
|
||
# Pants Daemon options. | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure what this means? In what way would a BinaryTool subclass be affected by the download location, and how would an author mitigate that in code?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: Also, I think the word is spelled "implementer".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I was thinking about how to make that more clear here. I was thinking specifically about what is done in the
LLVM
subsystem by overriding theselect()
method (and was going to explicitly call out that example here, but stopped short of doing that). Should I add in a comment describing that a bit (basically: we check if there's a single top-level directory and go down a level if so, or just return the result ofselect()
if the extraction doesn't put everything into a single top-level directory inside our specified extraction directory), or take this clause out of the docstring? Let me know if that made sense.The internet confirms that "implementer" is the correct spelling.