Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

warn or error on matching source globs #5769

Merged
merged 57 commits into from
May 31, 2018
Merged

warn or error on matching source globs #5769

merged 57 commits into from
May 31, 2018

Commits on May 30, 2018

  1. add formatting

    @cosmicexplorer
    cosmicexplorer committed May 30, 2018
    Configuration menu
    Copy the full SHA
    9e8e3f9 View commit details
    Browse the repository at this point in the history

  2. implement the rust side entirely

    @cosmicexplorer
    cosmicexplorer committed May 30, 2018
    Configuration menu
    Copy the full SHA
    1b8be97 View commit details
    Browse the repository at this point in the history

  3. add everything from the previous iteration

    @cosmicexplorer
    cosmicexplorer committed May 30, 2018
    Configuration menu
    Copy the full SHA
    237c143 View commit details
    Browse the repository at this point in the history

  4. hook it all up

    @cosmicexplorer
    cosmicexplorer committed May 30, 2018
    Configuration menu
    Copy the full SHA
    18e6d37 View commit details
    Browse the repository at this point in the history

  5. make everything work (but comment out the snapshots)

    @cosmicexplorer
    cosmicexplorer committed May 30, 2018
    Configuration menu
    Copy the full SHA
    0545e83 View commit details
    Browse the repository at this point in the history

  6. everything works -- time to see if perf is affected

    @cosmicexplorer
    cosmicexplorer committed May 30, 2018
    Configuration menu
    Copy the full SHA
    5937ab9 View commit details
    Browse the repository at this point in the history

  7. fix a test real quick

    @cosmicexplorer
    cosmicexplorer committed May 30, 2018
    Configuration menu
    Copy the full SHA
    48bc133 View commit details
    Browse the repository at this point in the history

  8. make note about "optimization"

    @cosmicexplorer
    cosmicexplorer committed May 30, 2018
    Configuration menu
    Copy the full SHA
    a875318 View commit details
    Browse the repository at this point in the history

  9. add feature flag to GlobMatchErrorBehavior

    @cosmicexplorer
    cosmicexplorer committed May 30, 2018
    Configuration menu
    Copy the full SHA
    7c2a91c View commit details
    Browse the repository at this point in the history

  10. fix imports

    @cosmicexplorer
    cosmicexplorer committed May 30, 2018
    Configuration menu
    Copy the full SHA
    9c15ca6 View commit details
    Browse the repository at this point in the history

  11. don't keep path stats in hash map during glob expansion

    @cosmicexplorer
    cosmicexplorer committed May 30, 2018
    Configuration menu
    Copy the full SHA
    049b528 View commit details
    Browse the repository at this point in the history

  12. don't re-eval each time we want a python bool

    @cosmicexplorer
    cosmicexplorer committed May 30, 2018
    Configuration menu
    Copy the full SHA
    44d1628 View commit details
    Browse the repository at this point in the history

  13. format rust

    @cosmicexplorer
    cosmicexplorer committed May 30, 2018
    Configuration menu
    Copy the full SHA
    d2661fc View commit details
    Browse the repository at this point in the history

  14. add tests, some fail, will fix

    @cosmicexplorer
    cosmicexplorer committed May 30, 2018
    Configuration menu
    Copy the full SHA
    d25d649 View commit details
    Browse the repository at this point in the history

  15. add todo

    @cosmicexplorer
    cosmicexplorer committed May 30, 2018
    Configuration menu
    Copy the full SHA
    1e1d03d View commit details
    Browse the repository at this point in the history

  16. a little bit of cleanup

    @cosmicexplorer
    cosmicexplorer committed May 30, 2018
    Configuration menu
    Copy the full SHA
    ec6e318 View commit details
    Browse the repository at this point in the history

  17. add fixme

    @cosmicexplorer
    cosmicexplorer committed May 30, 2018
    Configuration menu
    Copy the full SHA
    ccec075 View commit details
    Browse the repository at this point in the history

  18. implement fmt::Debug for Snapshot by providing Key#to_string()

    @cosmicexplorer
    cosmicexplorer committed May 30, 2018
    Configuration menu
    Copy the full SHA
    9ec9307 View commit details
    Browse the repository at this point in the history

  19. make the graph integration test into an integration test

    @cosmicexplorer
    cosmicexplorer committed May 30, 2018
    Configuration menu
    Copy the full SHA
    473e14f View commit details
    Browse the repository at this point in the history

  20. we should be warning now, but we're not for some reason

    @cosmicexplorer
    cosmicexplorer committed May 30, 2018
    Configuration menu
    Copy the full SHA
    7024613 View commit details
    Browse the repository at this point in the history

  21. remove eprintln!s

    @cosmicexplorer
    cosmicexplorer committed May 30, 2018
    Configuration menu
    Copy the full SHA
    8e47df6 View commit details
    Browse the repository at this point in the history

  22. revert the PathGlob changes you silly

    @cosmicexplorer
    cosmicexplorer committed May 30, 2018
    Configuration menu
    Copy the full SHA
    74f62d2 View commit details
    Browse the repository at this point in the history

  23. yeah there's no "regression"

    @cosmicexplorer
    cosmicexplorer committed May 30, 2018
    Configuration menu
    Copy the full SHA
    a1b72d4 View commit details
    Browse the repository at this point in the history

  24. refactor glob input matching to avoid re-traversing the whole tree at… 

    … the end
    @cosmicexplorer
    cosmicexplorer committed May 30, 2018
    Configuration menu
    Copy the full SHA
    1995a30 View commit details
    Browse the repository at this point in the history

  25. traverse from the leaves

    @cosmicexplorer
    cosmicexplorer committed May 30, 2018
    Configuration menu
    Copy the full SHA
    9f0ecc8 View commit details
    Browse the repository at this point in the history

  26. remove unused imports

    @cosmicexplorer
    cosmicexplorer committed May 30, 2018
    Configuration menu
    Copy the full SHA
    ab05ce1 View commit details
    Browse the repository at this point in the history

  27. provide a good error message

    @cosmicexplorer
    cosmicexplorer committed May 30, 2018
    Configuration menu
    Copy the full SHA
    fb985f1 View commit details
    Browse the repository at this point in the history

  28. make some tests pass, keep some tests failing

    @cosmicexplorer
    cosmicexplorer committed May 30, 2018
    Configuration menu
    Copy the full SHA
    c889ecb View commit details
    Browse the repository at this point in the history

  29. skip failing tests

    @cosmicexplorer
    cosmicexplorer committed May 30, 2018
    Configuration menu
    Copy the full SHA
    60938e2 View commit details
    Browse the repository at this point in the history

  30. unremove the trait use

    @cosmicexplorer
    cosmicexplorer committed May 30, 2018
    Configuration menu
    Copy the full SHA
    9f83274 View commit details
    Browse the repository at this point in the history

  31. remove unused From impl

    @cosmicexplorer
    cosmicexplorer committed May 30, 2018
    Configuration menu
    Copy the full SHA
    476c985 View commit details
    Browse the repository at this point in the history

  32. respond to some review comments

    @cosmicexplorer
    cosmicexplorer committed May 30, 2018
    Configuration menu
    Copy the full SHA
    b3d6480 View commit details
    Browse the repository at this point in the history

  33. use singletons for GlobMatchErrorBehavior.create()

    @cosmicexplorer
    cosmicexplorer committed May 30, 2018
    Configuration menu
    Copy the full SHA
    703e0e8 View commit details
    Browse the repository at this point in the history

  34. revert changes to structs.py

    @cosmicexplorer
    cosmicexplorer committed May 30, 2018
    Configuration menu
    Copy the full SHA
    6e7f5ad View commit details
    Browse the repository at this point in the history

  35. revert some more unneeded changes

    @cosmicexplorer
    cosmicexplorer committed May 30, 2018
    Configuration menu
    Copy the full SHA
    53dd5ac View commit details
    Browse the repository at this point in the history

  36. learn how to use project_ignoring_type

    @cosmicexplorer
    cosmicexplorer committed May 30, 2018
    Configuration menu
    Copy the full SHA
    4ebb556 View commit details
    Browse the repository at this point in the history

  37. move things that should go into a later pr into todos

    @cosmicexplorer
    cosmicexplorer committed May 30, 2018
    Configuration menu
    Copy the full SHA
    1ffa4a4 View commit details
    Browse the repository at this point in the history

  38. clean up PathGlobs.create() a bit

    @cosmicexplorer
    cosmicexplorer committed May 30, 2018
    Configuration menu
    Copy the full SHA
    775ceca View commit details
    Browse the repository at this point in the history

  39. edit todos to point to newly created issue

    @cosmicexplorer
    cosmicexplorer committed May 30, 2018
    Configuration menu
    Copy the full SHA
    0fc52cb View commit details
    Browse the repository at this point in the history

  40. clean up a little more

    @cosmicexplorer
    cosmicexplorer committed May 30, 2018
    Configuration menu
    Copy the full SHA
    3860dc8 View commit details
    Browse the repository at this point in the history

  41. quick cleanup

    @cosmicexplorer
    cosmicexplorer committed May 30, 2018
    Configuration menu
    Copy the full SHA
    3b8f8d5 View commit details
    Browse the repository at this point in the history

  42. document followup work

    @cosmicexplorer
    cosmicexplorer committed May 30, 2018
    Configuration menu
    Copy the full SHA
    af1ee61 View commit details
    Browse the repository at this point in the history

  43. skip another test for now

    @cosmicexplorer
    cosmicexplorer committed May 30, 2018
    Configuration menu
    Copy the full SHA
    ab209b9 View commit details
    Browse the repository at this point in the history

  44. make ci pass

    @cosmicexplorer
    cosmicexplorer committed May 30, 2018
    Configuration menu
    Copy the full SHA
    1c11a56 View commit details
    Browse the repository at this point in the history

  45. remove unused import

    @cosmicexplorer
    cosmicexplorer committed May 30, 2018
    Configuration menu
    Copy the full SHA
    72c2f39 View commit details
    Browse the repository at this point in the history

  46. remove some clone impls

    @cosmicexplorer
    cosmicexplorer committed May 30, 2018
    Configuration menu
    Copy the full SHA
    3c1a92c View commit details
    Browse the repository at this point in the history

  47. provide more error context in SourcesField#__str__()

    @cosmicexplorer
    cosmicexplorer committed May 30, 2018
    Configuration menu
    Copy the full SHA
    ec0ee4e View commit details
    Browse the repository at this point in the history

  48. add documentation for the amortized match checking strategy

    @cosmicexplorer
    cosmicexplorer committed May 30, 2018
    Configuration menu
    Copy the full SHA
    95f22cb View commit details
    Browse the repository at this point in the history

  49. refactor testing in response to review comments

    @cosmicexplorer
    cosmicexplorer committed May 30, 2018
    Configuration menu
    Copy the full SHA
    5b8d271 View commit details
    Browse the repository at this point in the history

  50. convert todo to just comment

    @cosmicexplorer
    cosmicexplorer committed May 30, 2018
    Configuration menu
    Copy the full SHA
    b0fde87 View commit details
    Browse the repository at this point in the history

  51. remove named TODOs

    @cosmicexplorer
    cosmicexplorer committed May 30, 2018
    Configuration menu
    Copy the full SHA
    8135983 View commit details
    Browse the repository at this point in the history

  52. fix lint

    @cosmicexplorer
    cosmicexplorer committed May 30, 2018
    Configuration menu
    Copy the full SHA
    7559715 View commit details
    Browse the repository at this point in the history

  53. fix compile errors, adding descriptive comments

    @cosmicexplorer
    cosmicexplorer committed May 30, 2018
    Configuration menu
    Copy the full SHA
    c8b96d8 View commit details
    Browse the repository at this point in the history

  54. pass lint and rearrange file

    @cosmicexplorer
    cosmicexplorer committed May 30, 2018
    Configuration menu
    Copy the full SHA
    a2e505f View commit details
    Browse the repository at this point in the history

  55. fix PathGlobs::create() calls and add some testing in engine/test_fs.py

    @cosmicexplorer
    cosmicexplorer committed May 30, 2018
    Configuration menu
    Copy the full SHA
    34e4aa9 View commit details
    Browse the repository at this point in the history

Commits on May 31, 2018

  1. remove repeated kwarg (an artifact from the rebase)

    @cosmicexplorer
    cosmicexplorer committed May 31, 2018
    Configuration menu
    Copy the full SHA
    ba772c4 View commit details
    Browse the repository at this point in the history

  2. add strange change -- watch before trying this again

    @cosmicexplorer
    cosmicexplorer committed May 31, 2018
    Configuration menu
    Copy the full SHA
    93ee21e View commit details
    Browse the repository at this point in the history