Add Javac compile option as an alternative to Zinc #5743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuhood
approved these changes
May 7, 2018
| logger = logging.getLogger(__name__) | ||
|
|
||
|
|
||
| class JvmCompileSubsystem(Subsystem): |
There was a problem hiding this comment.
It seems like this option could probably go on src/python/pants/backend/jvm/subsystems/jvm_platform.py instead as --jvm-platform-compiler?
| @@ -101,6 +102,31 @@ python_library( | |||
| sources = ['anonymizer.py'], | |||
| ) | |||
|
|
|||
| python_library( | |||
| name = 'javac', | |||
| sources = globs('javac/*.py'), | |||
There was a problem hiding this comment.
The convention in this file of defining targets outside of their directory is unfortunate... would recommend defining this target in that directory instead.
|
Oh... one or two integration tests (or a decorator that allows marking a test as run with both |
|
Chris and I discussed landing this now in order to ensure that #4729 doesn't break anything, and then making the remaining fixes later in the week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Zinc doesn't run on Java 9 or Java 10.
Solution
Provide the option to use Javac for java compilation instead of Zinc.
Result
This is first pass which is meant for discussion. I haven't updated tests or documentation, mainly just want to get feedback on what is there, and if the general pattern of using the subsystem is how we want to go.
It should be noted that there is no code analysis with Javac so any tasks that use analysis won't work.
To test it on the branch you need to add
to pants.ini