Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add back sdist generation and deployment. #4957

Merged
merged 1 commit into from
Oct 9, 2017

Conversation

jsirois
Copy link
Contributor

@jsirois jsirois commented Oct 8, 2017

This implements a workaround for pex lack of support for manylinux1
as outlined in #4956.

This implements a workaround for pex lack of support for `manylinux1`
as outlined in pantsbuild#4956.
@jsirois jsirois merged commit 89feae2 into pantsbuild:master Oct 9, 2017
@jsirois jsirois deleted the jsirois/issues/4956/workaround branch October 9, 2017 02:31
@kwlzn
Copy link
Member

kwlzn commented Oct 9, 2017

one potential alternative here would be to make a copy of the manylinux1_x86_64 bdist to with the platform filename subbed to linux_x86_64 and then publish that alongside the manylinux wheel. it should "just work" for the pex resolver, as manylinux1-x86_64 is essentially just a targeted subset of linux-x86_64.

I also have a branch adding manylinux support to pex that's 90% or more of the way there but I just haven't had time to devote to it in the face of other priorities.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants