Fix has_sources. #4792
Fix has_sources. #4792
Conversation
|
Came across this working #4780 |
jsirois
force-pushed
the
jsirois/issues/4780-fix-resources
branch
from
65d1463 to
2c9550a
Compare
| return self._ref_address | ||
|
|
||
| def has_sources(self, extension=None): | ||
| if not self.source_paths: | ||
| return False | ||
| if not extension: |
There was a problem hiding this comment.
Hm... "True if no extension" is an odd case. AFAICT, this method is only used in Target... would probably be good to inline the logic there so that it is more obvious that it is completely overridden by Resources. Would that also make this check unnecessary?
There was a problem hiding this comment.
The logic is actually if source_paths and not extension; ie at least 1 source and extension doesn't matter - so not so odd? Agreed its hard to read, but it is now tested at least.
There was a problem hiding this comment.
Ah, but the inlining makes sense maybe, I'll look at that...
Previously the default implementation failed to handle an extension of None even though it accepted the argument first class. This is fixed with test coverage added and Resources is fixed to delegate to the fixed implementation after performing its special check.
jsirois
force-pushed
the
jsirois/issues/4780-fix-resources
branch
from
2c9550a to
d1970e1
Compare
| Resources, | ||
| sources=Globs.create_fileset_with_spec('resources', '*.rs')) | ||
| self.assertFalse(no_resources.has_sources()) | ||
| self.assertFalse(no_resources.has_sources('*.java')) |
There was a problem hiding this comment.
Confused about the *.java here. Shouldn't it be just .java
There was a problem hiding this comment.
You're right, fixed.
| Resources, | ||
| sources=Globs.create_fileset_with_spec('resources', '*.java')) | ||
| self.assertTrue(resources.has_sources()) | ||
| self.assertFalse(resources.has_sources('*.java')) |
Previously the default implementation failed to handle an extension of
Noneeven though it accepted the argument first class. This is fixed with test
coverage added and
Resourcesis fixed to delegate to the fixed implementationafter performing its special check.