Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup and give better debug output for exclude patterns in findbugs and errorprone #4408

Conversation

cheister
Copy link
Contributor

Problem

For exclude patterns in errorprone and findbugs you don't get debug output telling you which exclude pattern was matched. Based on feedback received from @baroquebobcat

Solution

Loop through the exclude patterns and print debug output if one is matched

Copy link
Contributor

@baroquebobcat baroquebobcat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@cheister cheister merged commit 528f3a0 into pantsbuild:master Mar 31, 2017
@cheister cheister deleted the cleanup-findbugs-errorprone-exclude-patterns branch March 31, 2017 17:07
lenucksi pushed a commit to lenucksi/pants that referenced this pull request Apr 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants