Re-work native engine version. #4046
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is part of addressing #4035. |
This switches the `Native` subsystem to load the proper native engine library version from a resource file that is, in-turn, auto-managed by the pants script itself ensuring that pants, both in-repo and as a released package (pex or sdist or wheel), will always ask for the exact native engine library version it was built and tested with. A follow-up change will ensure we release a native engine library to bintray for all packaged releases, fulfilling the released pants package portion of the contract.
Things like isort now depend on a bootstrapped pants.
jsirois
force-pushed
the
jsirois/issues/4035
branch
from
51bcc81
to
d033c31
Compare
jsirois
force-pushed
the
jsirois/issues/4035
branch
from
16232dd
to
74e1cf2
Compare
|
It also addresses #4034 and restores |
|
Submitted @ cede1ec |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This switches the
Nativesubsystem to load the proper native enginelibrary version from a resource file that is, in-turn, auto-managed by
the pants script itself ensuring that pants, both in-repo and as a
released package (pex or sdist or wheel), will always ask for the exact
native engine library version it was built and tested with.
A follow-up change will ensure we release a native engine library to
bintray for all packaged releases, fulfilling the released pants package
portion of the contract.
https://rbcommons.com/s/twitter/r/4367/