Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Constrain the ICs in the coverage py integration tests. #21540

Merged
merged 1 commit into from
Oct 17, 2024
Merged

Constrain the ICs in the coverage py integration tests. #21540

merged 1 commit into from
Oct 17, 2024

Conversation

benjyw
Copy link
Contributor

@benjyw benjyw commented Oct 16, 2024

They are failing on release branches on the new ARM64 AMIs that
have Python 3.7-3.13 on them, because there is no pip that can be
installed on all those versions.

@benjyw benjyw added needs-cherrypick category:internal CI, fixes for not-yet-released features, etc. labels Oct 16, 2024
@benjyw benjyw added this to the 2.21.x milestone Oct 16, 2024
cburroughs
cburroughs approved these changes Oct 17, 2024
View reviewed changes
Copy link
Contributor

@cburroughs cburroughs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

(Wondering out loud if we need some sort of companion to all_major_minor_python_versions like all_major_minor_python_versions_with_supported_pip or something, or if if even less effort should be expended don EOL Pythons)

@benjyw benjyw merged commit 5f2c33a into pantsbuild:main Oct 17, 2024
25 checks passed
@benjyw benjyw deleted the fix_coverage_py_test branch October 17, 2024 09:35
WorkerPants pushed a commit that referenced this pull request Oct 17, 2024
@benjyw @WorkerPants
Constrain the ICs in the coverage py integration tests. (#21540)
a7fb2ec 
They are failing on release branches on the new ARM64 AMIs that
have Python 3.7-3.13 on them, because there is no pip that can be
installed on all those versions.
WorkerPants pushed a commit that referenced this pull request Oct 17, 2024
@benjyw @WorkerPants
Constrain the ICs in the coverage py integration tests. (#21540)
f79bdad 
They are failing on release branches on the new ARM64 AMIs that
have Python 3.7-3.13 on them, because there is no pip that can be
installed on all those versions.
WorkerPants pushed a commit that referenced this pull request Oct 17, 2024
@benjyw @WorkerPants
Constrain the ICs in the coverage py integration tests. (#21540)
b0f4351 
They are failing on release branches on the new ARM64 AMIs that
have Python 3.7-3.13 on them, because there is no pip that can be
installed on all those versions.
@benjyw
Copy link
Contributor Author

benjyw commented Oct 17, 2024

Thanks!

(Wondering out loud if we need some sort of companion to all_major_minor_python_versions like all_major_minor_python_versions_with_supported_pip or something, or if if even less effort should be expended don EOL Pythons)

Well, I think the real solution is to eliminate loose interpreter constraints, and require you to select one or more specific interpreters for which we generate complete_platform files...

@WorkerPants
Copy link
Member

I tried to automatically cherry-pick this change back to each relevant milestone, so that it is available in those older releases of Pants.

✔️ 2.21.x

Successfully opened #21541.

✔️ 2.22.x

Successfully opened #21543.

✔️ 2.23.x

Successfully opened #21542.

Thanks again for your contributions!

🤖 Beep Boop here's my run link

benjyw added a commit that referenced this pull request Oct 17, 2024
@WorkerPants @benjyw
Constrain the ICs in the coverage py integration tests. (Cherry-pick of
0acd3b1 
#21540) (#21541)

They are failing on release branches on the new ARM64 AMIs that
have Python 3.7-3.13 on them, because there is no pip that can be
installed on all those versions.

Co-authored-by: Benjy Weinberger <benjyw@gmail.com>
benjyw added a commit that referenced this pull request Oct 17, 2024
@WorkerPants @benjyw
Constrain the ICs in the coverage py integration tests. (Cherry-pick of
dccb093 
#21540) (#21542)

They are failing on release branches on the new ARM64 AMIs that
have Python 3.7-3.13 on them, because there is no pip that can be
installed on all those versions.

Co-authored-by: Benjy Weinberger <benjyw@gmail.com>
benjyw added a commit that referenced this pull request Oct 17, 2024
@WorkerPants @benjyw
Constrain the ICs in the coverage py integration tests. (Cherry-pick of
fcc5e50 
#21540) (#21543)

They are failing on release branches on the new ARM64 AMIs that
have Python 3.7-3.13 on them, because there is no pip that can be
installed on all those versions.

Co-authored-by: Benjy Weinberger <benjyw@gmail.com>
@benjyw benjyw mentioned this pull request Oct 17, 2024
Merged
benjyw added a commit that referenced this pull request Oct 17, 2024
@benjyw
Fix the remaining coverage py integration tests (#21544)
eb8b6d7 
Follow up to #21540, which alas only tackled half the tests
(and those do indeed pass on the new ARM images, so this
change should now cause the rest to pass).
WorkerPants pushed a commit that referenced this pull request Oct 17, 2024
@benjyw @WorkerPants
Fix the remaining coverage py integration tests (#21544)
7b91446 
Follow up to #21540, which alas only tackled half the tests
(and those do indeed pass on the new ARM images, so this
change should now cause the rest to pass).
WorkerPants pushed a commit that referenced this pull request Oct 17, 2024
@benjyw @WorkerPants
Fix the remaining coverage py integration tests (#21544)
2e40727 
Follow up to #21540, which alas only tackled half the tests
(and those do indeed pass on the new ARM images, so this
change should now cause the rest to pass).
WorkerPants pushed a commit that referenced this pull request Oct 17, 2024
@benjyw @WorkerPants
Fix the remaining coverage py integration tests (#21544)
92a05be 
Follow up to #21540, which alas only tackled half the tests
(and those do indeed pass on the new ARM images, so this
change should now cause the rest to pass).
This was referenced Oct 17, 2024
Merged
Merged
Merged
benjyw added a commit that referenced this pull request Oct 17, 2024
@WorkerPants @benjyw
Fix the remaining coverage py integration tests (Cherry-pick of #21544)…
980ed28 
… (#21548)

Follow up to #21540, which alas only tackled half the tests
(and those do indeed pass on the new ARM images, so this
change should now cause the rest to pass).

Co-authored-by: Benjy Weinberger <benjyw@gmail.com>
benjyw added a commit that referenced this pull request Oct 17, 2024
@WorkerPants @benjyw
Fix the remaining coverage py integration tests (Cherry-pick of #21544)…
c325fa8 
… (#21547)

Follow up to #21540, which alas only tackled half the tests
(and those do indeed pass on the new ARM images, so this
change should now cause the rest to pass).

Co-authored-by: Benjy Weinberger <benjyw@gmail.com>
benjyw added a commit that referenced this pull request Oct 17, 2024
@WorkerPants @benjyw
Fix the remaining coverage py integration tests (Cherry-pick of #21544)…
cbb7611 
… (#21546)

Follow up to #21540, which alas only tackled half the tests
(and those do indeed pass on the new ARM images, so this
change should now cause the rest to pass).

Co-authored-by: Benjy Weinberger <benjyw@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cburroughs cburroughs cburroughs approved these changes

Assignees
No one assigned
Labels
category:internal CI, fixes for not-yet-released features, etc.
Projects
None yet
Milestone
2.21.x
Development

Successfully merging this pull request may close these issues.
3 participants
@benjyw @WorkerPants @cburroughs