Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the ARM64 CI AMI. #21531

Merged
merged 2 commits into from
Oct 16, 2024
Merged

Conversation

benjyw
Copy link
Contributor

@benjyw benjyw commented Oct 16, 2024

This AMI will have all pythons from 3.7 to 3.13 preinstalled.

Also update the docs on how to create it.

This AMI will have all pythons from 3.7 to 3.13 preinstalled.

Also update the docs on how to create it.
@benjyw benjyw added needs-cherrypick category:internal CI, fixes for not-yet-released features, etc. labels Oct 16, 2024
@benjyw benjyw added this to the 2.21.x milestone Oct 16, 2024
@benjyw
Copy link
Contributor Author

benjyw commented Oct 16, 2024

This will be cherrypicked to all active release branches so that we can reap the old AMIs sooner (RunsOn make no guarantees about continuing to work on older AMIs, so this sort of cherrypicking is going to be necessary from time to time).

@benjyw
Copy link
Contributor Author

benjyw commented Oct 16, 2024

Hmm, will have to merge the label changes separately, since the new AMI only takes effect after merging, but the label changes take effect in this PR.

@benjyw benjyw merged commit fe33266 into pantsbuild:main Oct 16, 2024
25 checks passed
@benjyw benjyw deleted the all_pythons_in_arm64_ci branch October 16, 2024 16:39
WorkerPants pushed a commit that referenced this pull request Oct 16, 2024
This AMI will have all pythons from 3.7 to 3.13 preinstalled.

Also update the docs on how to create it.
@WorkerPants
Copy link
Member

I tried to automatically cherry-pick this change back to each relevant milestone, so that it is available in those older releases of Pants.

❌ 2.21.x

I was unable to cherry-pick this PR to 2.21.x, likely due to merge-conflicts.

Steps to Cherry-Pick locally

To resolve:

  1. (Ensure your git working directory is clean)
  2. Run the following script to reproduce the merge-conflicts:
    git fetch https://github.com/pantsbuild/pants main \
      && git fetch https://github.com/pantsbuild/pants 2.21.x \
      && git checkout -b cherry-pick-21531-to-2.21.x FETCH_HEAD \
      && git cherry-pick fe332667d1839962d4bdfa852d6bd68c6c98424f
  3. Fix the merge conflicts and commit the changes
  4. Run build-support/cherry_pick/make_pr.sh "21531" "2.21.x"

Please note that I cannot re-run CI if a job fails. Please work with your PR approver(s) to re-run CI if necessary.

❌ 2.22.x

I was unable to cherry-pick this PR to 2.22.x, likely due to merge-conflicts.

Steps to Cherry-Pick locally

To resolve:

  1. (Ensure your git working directory is clean)
  2. Run the following script to reproduce the merge-conflicts:
    git fetch https://github.com/pantsbuild/pants main \
      && git fetch https://github.com/pantsbuild/pants 2.22.x \
      && git checkout -b cherry-pick-21531-to-2.22.x FETCH_HEAD \
      && git cherry-pick fe332667d1839962d4bdfa852d6bd68c6c98424f
  3. Fix the merge conflicts and commit the changes
  4. Run build-support/cherry_pick/make_pr.sh "21531" "2.22.x"

Please note that I cannot re-run CI if a job fails. Please work with your PR approver(s) to re-run CI if necessary.

✔️ 2.23.x

Successfully opened #21533.


When you're done manually cherry-picking, please remove the needs-cherrypick label on this PR.

Thanks again for your contributions!

🤖 Beep Boop here's my run link

@WorkerPants WorkerPants added the auto-cherry-picking-failed Auto Cherry-Picking Failed label Oct 16, 2024
benjyw added a commit to benjyw/pants that referenced this pull request Oct 16, 2024
This AMI will have all pythons from 3.7 to 3.13 preinstalled.

Also update the docs on how to create it.
benjyw added a commit to benjyw/pants that referenced this pull request Oct 16, 2024
This AMI will have all pythons from 3.7 to 3.13 preinstalled.

Also update the docs on how to create it.
benjyw added a commit that referenced this pull request Oct 16, 2024
This AMI will have all pythons from 3.7 to 3.13 preinstalled.

Also update the docs on how to create it.
benjyw added a commit that referenced this pull request Oct 16, 2024
This AMI will have all pythons from 3.7 to 3.13 preinstalled.

Also update the docs on how to create it.
benjyw added a commit that referenced this pull request Oct 16, 2024
This AMI will have all pythons from 3.7 to 3.13 preinstalled.

Also update the docs on how to create it.

Co-authored-by: Benjy Weinberger <benjyw@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-cherry-picking-failed Auto Cherry-Picking Failed category:internal CI, fixes for not-yet-released features, etc. needs-cherrypick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants