Move check_inits.py into Pants
#19919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thejcannon
added
the
category:internal
Eric-Arellano
approved these changes
Sep 22, 2023
| ) | ||
|
|
||
| # NB: This should be in `lint` when we implement `lint` in https://github.com/pantsbuild/pants/issues/17729 | ||
| experimental_test_shell_command( |
There was a problem hiding this comment.
I know nothing about this. How do you invoke it?
There was a problem hiding this comment.
It gets executed as part of the test goal! 🎉
|
@huonw also likely something to toss into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change moves the pre-commit-hook (which ummm is that run in CI?!?!?!) into an
experimental_test_shell_command.