adds EnvironmentField to pex_binary and related generators
#17435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eric-Arellano
approved these changes
Nov 2, 2022
chrisjrn
added
the
category:internal
stuhood
approved these changes
Nov 2, 2022
Eric-Arellano
approved these changes
Nov 2, 2022
|
Unclear why this PR is failing -- apparently pex is running under Python 3.11 and failing to fetch an artifact? |
chrisjrn
pushed a commit
to chrisjrn/pants
that referenced
this pull request
Nov 3, 2022
…build#17435) This adds an `environment` field to `pex_binary`/`pex_binaries` etc. The `package` goal already injects the `EnvironmentName` from the `EnvironmentField` into the relevant pex rules by way of `EnvironmentAwarePackageRequest`, this change just makes it possible to supply that value. Closes pantsbuild#17428
chrisjrn
pushed a commit
that referenced
this pull request
Nov 3, 2022
…y-pick of #17435) (#17457) This adds an `environment` field to `pex_binary`/`pex_binaries` etc. The `package` goal already injects the `EnvironmentName` from the `EnvironmentField` into the relevant pex rules by way of `EnvironmentAwarePackageRequest`, this change just makes it possible to supply that value. Closes #17428
chrisjrn
pushed a commit
to chrisjrn/pants
that referenced
this pull request
Nov 3, 2022
…build#17435) This adds an `environment` field to `pex_binary`/`pex_binaries` etc. The `package` goal already injects the `EnvironmentName` from the `EnvironmentField` into the relevant pex rules by way of `EnvironmentAwarePackageRequest`, this change just makes it possible to supply that value. Closes pantsbuild#17428 # Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an
environmentfield topex_binary/pex_binariesetc.The
packagegoal already injects theEnvironmentNamefrom theEnvironmentFieldinto the relevant pex rules by way ofEnvironmentAwarePackageRequest, this change just makes it possible to supply that value.Closes #17428