Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[internal] use CAS BatchReadBlobs API for small blob reads (#15969)" #16014

Closed
wants to merge 1 commit into from

Conversation

kaos
Copy link
Member

@kaos kaos commented Jun 30, 2022

Reverts #15969

This reverts commit 5874884.

This resolves an issue with running ./pants check on more than just a few files.

…antsbuild#15969)"

This reverts commit 5874884.

This resolves and issue with running `./pants check` on more than just a few files.
@kaos kaos added the category:internal CI, fixes for not-yet-released features, etc. label Jun 30, 2022
@kaos kaos requested a review from tdyas June 30, 2022 10:10
@kaos
Copy link
Member Author

kaos commented Jun 30, 2022

Commit identified according to git bisect for

$ ./pants --no-pantsd --no-dynamic-ui -ltrace check src/python/pants/backend/docker/util_rules:

My rust is rusty (no, not even that, as it's never been anything) so I haven't even tried to understand what this does or why/why not.

@kaos
Copy link
Member Author

kaos commented Jun 30, 2022

I've also not skipped the build wheels step on purpose, to see if this also is related to that issue.

@kaos
Copy link
Member Author

kaos commented Jun 30, 2022

Superseded by #16016

@kaos kaos closed this Jun 30, 2022
@kaos kaos deleted the fix_check_issue branch November 24, 2022 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:internal CI, fixes for not-yet-released features, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant