Enrich MissingDigest errors when we fail to recover from them
#16008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n order to differentiate uncaught cases from those where we just cannot determine the source. # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
stuhood
added
the
category:internal
|
This does not fix #15995, but it will rule out some possibilities for the source of the error. |
tdyas
approved these changes
Jun 29, 2022
Eric-Arellano
approved these changes
Jun 29, 2022
Not necessarily... this is as much to assist with triage of #15995 on |
stuhood
deleted the
stuhood/differentiate-recovery-failures-from-uncaught-cases
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to differentiate "uncaught"
MissingDigestcases (where aMissingDigesterror is converted into a string rather than being handled at theNodeboundary) from those where we just cannot determine the source, enrich the latter case.[ci skip-build-wheels]