Improvements to CI job generation. #15989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that the proof of the pudding is in the fact that the generated file diffs are exactly what we expect. |
Eric-Arellano
approved these changes
Jun 29, 2022
- Refactor out the per-platform job generation. - Ensure names are properly platform-qualified. - Add a "Merge OK" job that depends on all the other jobs, so that branch protection only needs to know about that one, instead of an ever changing list of job names. - Inject the dep on check_labels automatically, and only in PR jobs (cron-triggered jobs don't need this).
benjyw
force-pushed
the
ci_gen_improvements
branch
2 times, most recently
from
deccf27
to
d05e35d
Compare
benjyw
added a commit
to benjyw/pants
that referenced
this pull request
Jul 5, 2022
- Refactor out the per-platform job generation. - Ensure names are properly platform-qualified. - Add a "Merge OK" job that depends on all the other jobs, so that branch protection only needs to know about that one, instead of an ever changing list of job names. - Inject the dep on check_labels automatically, and only in PR jobs (cron-triggered jobs don't need this).
benjyw
added a commit
that referenced
this pull request
Jul 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
so that branch protection only needs to know about that one,
instead of an ever changing list of job names.
in PR jobs (cron-triggered jobs don't need this).