[internal] add mark and fixture for lockfile generation, take #2 #15271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdyas
force-pushed
the
jvm_test_lockfiles_put_back
branch
from
e491729 to
6be345d
Compare
stuhood
approved these changes
Apr 27, 2022
|
|
tdyas
force-pushed
the
jvm_test_lockfiles_put_back
branch
from
c2bd3c1 to
38a75f2
Compare
added 7 commits
May 7, 2022 01:08
…on (pantsbuild#15190)" (pantsbuild#15267)" This reverts commit 21f8a51. # Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust]
# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust]
# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust]
[ci skip-rust]
[ci skip-rust]
[ci skip-rust] [ci skip-build-wheels]
tdyas
force-pushed
the
jvm_test_lockfiles_put_back
branch
6 times, most recently
from
e653deb to
ff0e020
Compare
[ci skip-rust]
tdyas
force-pushed
the
jvm_test_lockfiles_put_back
branch
from
40af86c to
adbe3ca
Compare
tdyas
commented
May 9, 2022
tdyas
changed the title
stuhood
approved these changes
May 9, 2022
Eric-Arellano
approved these changes
May 9, 2022
pants-plugins/internal_plugins/test_lockfile_fixtures/lockfile_fixture.py
Outdated
Show resolved
Hide resolved
added 2 commits
May 9, 2022 14:11
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a
jvm_lockfilepytest fixture and related custom markpytest.mark.jvm_lockfilefor defining lockfiles for use in tests. This allows avoiding having to replicate lockfile content in code usingTestCoursierWrapper, which can become unwiedly once a resolve in complicated enough.Lockfiles are generated by running
./pants internal-generate-test-lockfile-fixtures ::which collects all tests marked withpytest.mark.jvm_lockfile, resolves their requirements, and writes out the resulting lockfiles. A custom Pants goal is used so that the plugin code gets access to the Pants source tree and targets. (An earlier iteration of this PR tried to use aRuleRunnerin a script underbuild-support/bin, butRuleRunneris used for testing in an isolated directory and has no access to the Pants repository sources.)