Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not use [python-setup].resolve_all_constraints when using platforms #12268

Conversation

wilsonliam
Copy link
Contributor

Closes #12222 and adds an associated test for this edge case.

[ci skip-rust]
[ci skip-build-wheels]

# Rust tests and lints will be skipped. Delete if not intended.
[ci skip-rust]

# Building wheels and fs_util will be skipped. Delete if not intended.
[ci skip-build-wheels]
Copy link
Contributor

@Eric-Arellano Eric-Arellano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Liam! FYI I updated the PR title.

@Eric-Arellano Eric-Arellano changed the title Fixed dependency issues with cross-platform targets (closes #12222) Do not use [python-setup].resolve_all_constraints when using platforms Jul 2, 2021
@Eric-Arellano Eric-Arellano merged commit 38780c5 into pantsbuild:main Jul 2, 2021
wilsonliam added a commit to wilsonliam/pants that referenced this pull request Jul 2, 2021
…orms` (pantsbuild#12268)

Closes pantsbuild#12222 and adds an associated test for this edge case.

[ci skip-rust]
[ci skip-build-wheels]
wilsonliam added a commit to wilsonliam/pants that referenced this pull request Jul 2, 2021
…orms` (pantsbuild#12268)

Closes pantsbuild#12222 and adds an associated test for this edge case.

[ci skip-rust]
[ci skip-build-wheels]
Eric-Arellano pushed a commit that referenced this pull request Jul 2, 2021
…orms` (Cherry-pick of #12268) (#12269)

[ci skip-rust]
[ci skip-build-wheels]
Eric-Arellano pushed a commit that referenced this pull request Jul 2, 2021
…orms` (Cherry-pick of #12268) (#12270)

[ci skip-rust]
[ci skip-build-wheels]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pants 2.5 dependency issues with cross-platform targets
2 participants