Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade setuptools from 49.2.0 to 49.2.1 #10561

Closed
wants to merge 5 commits into from

Conversation

asherf
Copy link
Member

@asherf asherf commented Aug 6, 2020

https://github.com/pypa/setuptools/releases/tag/v49.2.1

pypa/setuptools#2257: Fixed two flaws in distutils._msvccompiler.MSVCCompiler.spawn.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 0.0% when pulling ce6d115 on asherf:upgrades into 6c90064 on pantsbuild:master.

Copy link
Contributor

@Eric-Arellano Eric-Arellano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about pinning the version to `>=49.2.1,<49.3'? Then we don't need to update this as frequently.

Copy link
Contributor

@Eric-Arellano Eric-Arellano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Asher!

@@ -9,7 +9,4 @@ class Lambdex(PythonToolBase):

options_scope = "lambdex"
default_version = "lambdex==0.1.3"
# TODO(John Sirois): Remove when we can upgrade to a version of lambdex with
# https://github.com/wickman/lambdex/issues/6 fixed.
default_extra_requirements = ["setuptools==49.2.0"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That TODO isn't resolved, I think we still need setuptools.

Instead, we either want to

  1. Keep the upgrade to >=49.2.1,<49.3 and add the class property default_interpreter_constraints = ["CPython>=3.6"]
  2. Change the version to <45 so that it works with Python 2.

@asherf asherf closed this Aug 10, 2020
@asherf asherf deleted the upgrades branch August 10, 2020 16:50
Eric-Arellano pushed a commit that referenced this pull request Aug 16, 2020
https://github.com/pypa/setuptools/releases/tag/v49.6.0

https://github.com/pypa/setuptools/blob/master/CHANGES.rst

* #2129: In pkg_resources, no longer detect any pathname ending in .egg as a Python egg. Now the path must be an unpacked egg or a zip file.
* #2306: When running as a PEP 517 backend, setuptools does not try to install
  ``setup_requires`` itself. They are reported as build requirements for the
  frontend to install.
* #2310: Updated vendored packaging version to 20.4.
* #2300: Improve the ``safe_version`` function documentation
* #2297: Once again, in stubs prefer exec_module to the deprecated load_module.
* #2316: Removed warning when ``distutils`` is imported before ``setuptools`` when ``distutils`` replacement is not enabled.
* #2259: Setuptools now provides a .pth file (except for editable installs of setuptools) to the target environment to ensure that when enabled, the setuptools-provided distutils is preferred before setuptools has been imported (and even if setuptools is never imported). Honors the SETUPTOOLS_USE_DISTUTILS environment variable.
pypa/setuptools#2257: Fixed two flaws in distutils._msvccompiler.MSVCCompiler.spawn.

instead of #10561

[ci skip-build-wheels]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants